Correctly invoke the exported cast functions.

chrome/browser/ui/ash/cast_config_delegate_chromeos.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/cast_config_delegate_chromeos.h"
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 109 matching lines @@
 
 CastConfigDelegateChromeos::~CastConfigDelegateChromeos() {
 }
 
 bool CastConfigDelegateChromeos::HasCastExtension() const {
   return FindCastExtension() != nullptr;
 }
 
 void CastConfigDelegateChromeos::GetReceiversAndActivities(
     const ReceiversAndActivitesCallback& callback) {
+  // The methods in backgroundSetup are renamed during minification, so we have
+  // to bind the exported global API methods to backgroundSetup using call().
   ExecuteJavaScriptWithCallback(
-      "backgroundSetup.getMirrorCapableReceiversAndActivities();",
+      "getMirrorCapableReceiversAndActivities.call(backgroundSetup);",
       base::Bind(&GetReceiversAndActivitiesCallback, callback));
 }
 
 void CastConfigDelegateChromeos::CastToReceiver(
     const std::string& receiver_id) {
-  ExecuteJavaScript("backgroundSetup.launchDesktopMirroring('" + receiver_id +
-                    "');");
+  // The methods in backgroundSetup are renamed during minification, so we have
+  // to bind the exported global API methods to backgroundSetup using call().
+  ExecuteJavaScript("launchDesktopMirroring.call(backgroundSetup, '" +
+                    receiver_id + "');");
 }
 
 void CastConfigDelegateChromeos::StopCasting() {
-  ExecuteJavaScript("backgroundSetup.stopMirroring('user-stop')");
+  // The methods in backgroundSetup are renamed during minification, so we have
+  // to bind the exported global API methods to backgroundSetup using call().
+  ExecuteJavaScript("stopMirroring.call(backgroundSetup, 'user-stop');");
 
   // TODO(jdufault): Remove this after the beta/release versions of the
   // cast extension have been updated so that they properly export the
   // stopMirroring function. For now, we try to invoke all of the other
   // names that the function goes by. See crbug.com/489929.
-  ExecuteJavaScript("backgroundSetup.stopCastMirroring('user-stop');");
   ExecuteJavaScript("backgroundSetup.Qu('user-stop');");

[achuithb, 2015/06/08 19:09:42]

Do you need this? This is a work-around for minification, right?

[achuithb, 2015/06/08 19:10:38]

Or was this necessary because the symbol was not yet exported?

[jdufault, 2015/06/08 19:16:19]

Right, the symbol was not exported yet. So we workaround the minification by
calling the minified symbol. This will go away in a week or two when the release
version of the cast extension is updated.

[achuithb, 2015/06/08 19:18:47]

Could we file a bug so we can track this? And reference it here? Just to make
sure we don't accumulate cruft.

[jdufault, 2015/06/08 19:29:49]

Yep, see the comment above. The bug is at crbug.com/489929

[achuithb, 2015/06/08 19:31:17]

Ah, oops. you're right.

 }
 
 void CastConfigDelegateChromeos::LaunchCastOptions() {
   chrome::NavigateParams params(
       ProfileManager::GetActiveUserProfile(),
       FindCastExtension()->GetResourceURL("options.html"),
       ui::PAGE_TRANSITION_LINK);
   params.disposition = NEW_FOREGROUND_TAB;
   params.window_action = chrome::NavigateParams::SHOW_WINDOW;
   chrome::Navigate(&params);
 }
 
 }  // namespace chromeos