Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: build/config/mac/mac_sdk.gni

Issue 116763005: GN: Get Mac build working for IPC target at least. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make mac_sdk.gni more generally useful. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/mac/mac_sdk.gni
diff --git a/build/config/mac/mac_sdk.gni b/build/config/mac/mac_sdk.gni
new file mode 100644
index 0000000000000000000000000000000000000000..b9fb530cb46611790974e1cef531c260e36b6a9b
--- /dev/null
+++ b/build/config/mac/mac_sdk.gni
@@ -0,0 +1,25 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+declare_args() {
+ # Minimum supported version of the Mac SDK.
+ mac_sdk_min = "10.6"
+
+ # Path to a specific version of the Mac SDK.
brettw 2014/01/08 18:43:44 Can you document the behavior if it's left empty?
bbudge 2014/01/08 20:22:55 Done.
+ mac_sdk_path = ""
+}
+
+if (is_chrome_branded && is_official_build) {
+ find_sdk_args = ["--verify", mac_sdk_min "--sdk_path=" + mac_sdk_path]
brettw 2014/01/08 18:43:44 Can you put spaces inside the [] here and below (b
+} else {
+ find_sdk_args = [mac_sdk_min]
+}
+# Use "list lines" and take the first to get version string without a newline.
+find_sdk_lines =
+ exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines")
+mac_sdk_version = find_sdk_lines[0]
+if (mac_sdk_path == "") {
+ mac_sdk_root = "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX"
+ mac_sdk_path = mac_sdk_root + mac_sdk_version + ".sdk"
+}

Powered by Google App Engine
This is Rietveld 408576698