Issue 1167623005: Manual merging of fix for platform handle passing on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1167623005: Manual merging of fix for platform handle passing on Windows. (Closed)

Created:
5 years, 6 months ago by jam

Modified:
5 years, 6 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Manual merging of fix for platform handle passing on Windows. This landed in https://chromium.googlesource.com/external/mojo/+/a500628dfc647cc520d999a972b80d9ff62b0b26, but I want to use it now in the Chromium repo. BUG=478251 Committed: https://crrev.com/a2eca7bf2921ad7b1f4223c1cdea24d57abd8eba Cr-Commit-Position: refs/heads/master@{#333075}

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	third_party/mojo/src/mojo/edk/system/raw_channel_win.cc	View		8 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167623005/1

5 years, 6 months ago (2015-06-05 17:02:15 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 17:06:58 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a2eca7bf2921ad7b1f4223c1cdea24d57abd8eba
Cr-Commit-Position: refs/heads/master@{#333075}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages