Issue 1167613004: Fix more -Wsign-compare bugs with GCC 4.9.2.

Issue 1167613004: Fix more -Wsign-compare bugs with GCC 4.9.2. (Closed)

Created:
5 years, 6 months ago by paul.l...

Modified:
5 years, 6 months ago

Reviewers:
Benedikt Meurer, Sven Panne, adamk

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix more -Wsign-compare bugs with GCC 4.9.2. BUG= Committed: https://crrev.com/21585d55c1b9a6f787a3ad873a9f26d3a9703e5a Cr-Commit-Position: refs/heads/master@{#28798}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -93 lines)			Patch
M	test/cctest/test-api.cc	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	test/cctest/test-assembler-mips64.cc	View	2 chunks	+80 lines, -80 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/unittests/compiler/common-operator-unittest.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 11 (4 generated)

paul.l...

Even more of the these silly sign errors with gcc. PTAL.

5 years, 6 months ago (2015-06-04 00:38:03 UTC) #2

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167613004/1

5 years, 6 months ago (2015-06-04 00:41:08 UTC) #4

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 6 months ago (2015-06-04 01:08:07 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167613004/1

5 years, 6 months ago (2015-06-04 01:26:52 UTC) #9

commit-bot: I haz the power

5 years, 6 months ago (2015-06-04 01:28:39 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/21585d55c1b9a6f787a3ad873a9f26d3a9703e5a
Cr-Commit-Position: refs/heads/master@{#28798}