Issue 11676005: postmortem: export kSmiShiftSize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11676005: postmortem: export kSmiShiftSize (Closed)

Created:
7 years, 12 months ago by indutny

Modified:
7 years, 12 months ago

Reviewers:
Erik Corry

Base URL:
gh:v8/v8@master

Visibility:
Public.

postmortem: export kSmiShiftSize Right now it's impossible to figure out from headers that smis are left shifted by 31 bit on x64, and only then tagged. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=13285

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/gen-postmortem-metadata.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

indutny

On 2012/12/27 03:25:25, indutny wrote: Please also consider porting it to 3.13... and probably 3.14. ...

7 years, 12 months ago (2012-12-27 03:26:07 UTC) #2

Erik Corry

I think it would be more accurate to say that Smis are tagged by shifting ...

7 years, 12 months ago (2012-12-28 11:56:48 UTC) #3

indutny

7 years, 12 months ago (2012-12-28 12:51:34 UTC) #5

On 2012/12/28 12:00:38, Erik Corry wrote:
> LGTM

Cool! Any chance to backport it?