Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1167563005: Make old generation allocation throughput stats independent from the new space allocation throughpu… (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make old generation allocation throughput stats independent from the new space allocation throughput. BUG= Committed: https://crrev.com/7e53749df0a10f475404e86ef0ca8df02bb79e7a Cr-Commit-Position: refs/heads/master@{#28880}

Patch Set 1 #

Patch Set 2 : Rework HasLowAllocationRate #

Patch Set 3 : Fix tests #

Patch Set 4 : cast #

Patch Set 5 : cast #

Patch Set 6 : cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -51 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 2 chunks +1 line, -1 line 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 1 2 3 3 chunks +15 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 2 3 4 7 chunks +53 lines, -21 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 5 chunks +36 lines, -16 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
ulan
Small refactoring to allow getting old generation allocation throughput without new space allocation throughput.
5 years, 6 months ago (2015-06-08 10:36:05 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 6 months ago (2015-06-08 21:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167563005/60001
5 years, 6 months ago (2015-06-09 15:21:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/5507)
5 years, 6 months ago (2015-06-09 15:49:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167563005/80001
5 years, 6 months ago (2015-06-09 16:04:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/5512)
5 years, 6 months ago (2015-06-09 16:18:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167563005/100001
5 years, 6 months ago (2015-06-09 16:43:01 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 6 months ago (2015-06-09 17:49:47 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 17:50:07 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7e53749df0a10f475404e86ef0ca8df02bb79e7a
Cr-Commit-Position: refs/heads/master@{#28880}

Powered by Google App Engine
This is Rietveld 408576698