Sync the XHR-related interfaces with the spec

Source/core/xmlhttprequest/XMLHttpRequest.idl

Index: Source/core/xmlhttprequest/XMLHttpRequest.idl
diff --git a/Source/core/xmlhttprequest/XMLHttpRequest.idl b/Source/core/xmlhttprequest/XMLHttpRequest.idl
index 8aadc72283c72ec7446febf4cd5f236ae68734c6..b73e397990656c12b2e15ad5f202835c8ae6e2d8 100644
--- a/Source/core/xmlhttprequest/XMLHttpRequest.idl
+++ b/Source/core/xmlhttprequest/XMLHttpRequest.idl
@@ -39,11 +39,15 @@ enum XMLHttpRequestResponseType {
     "stream"
 };
 
+// TODO(philipj): Most DOMString types in the XMLHttpRequest interface should be
+// either ByteString or USVString.
 [
     WillBeGarbageCollected,
     ActiveDOMObject,
     Constructor,
     ConstructorCallWith=ScriptState,
+    // TODO(philipj): The spec has Exposed=(Window,Worker)
+    // https://github.com/whatwg/xhr/issues/19
     Exposed=(Window,DedicatedWorker,SharedWorker)
 ] interface XMLHttpRequest : XMLHttpRequestEventTarget {
     // event handler
@@ -58,23 +62,26 @@ enum XMLHttpRequestResponseType {
     readonly attribute unsigned short readyState;
 
     // request
-    [RaisesException] void open(DOMString method, DOMString url, optional boolean async, [TreatUndefinedAs=NullString] optional DOMString? user, [TreatUndefinedAs=NullString] optional DOMString? password);
-    [RaisesException] void setRequestHeader(DOMString header, DOMString value);
+    [RaisesException] void open(DOMString method, DOMString url);
+    [RaisesException] void open(DOMString method, DOMString url, boolean async, optional DOMString? username = null, optional DOMString? password = null);
+    [RaisesException] void setRequestHeader(DOMString name, DOMString value);
     [RaisesException=Setter] attribute unsigned long timeout;
     [RaisesException=Setter] attribute boolean withCredentials;
     readonly attribute XMLHttpRequestUpload upload;
-    [RaisesException] void send(optional (ArrayBuffer or ArrayBufferView or Blob or Document or DOMString or FormData)? data);
+    // TODO(philipj): The data argument should be of type (Document or BodyInit)?

[yhirano, 2015/06/01 01:25:12]

Please wrap the comment in 80 columns.

[philipj_slow, 2015/06/01 11:59:54]

Done.

+    [RaisesException] void send(optional (ArrayBuffer or ArrayBufferView or Blob or Document or DOMString or FormData)? data = null);

[yhirano, 2015/06/01 01:25:12]

The parameter name should be |body| instead of |data|?

[philipj_slow, 2015/06/01 11:59:54]

Done.

     void abort();
 
     // response
     readonly attribute DOMString responseURL;
     readonly attribute unsigned short status;
     readonly attribute DOMString statusText;
-    DOMString? getResponseHeader(DOMString header);
-    [TreatReturnedNullStringAs=Undefined] DOMString getAllResponseHeaders();
-    [RaisesException] void overrideMimeType(DOMString override);
+    DOMString? getResponseHeader(DOMString name);
+    DOMString getAllResponseHeaders();
+    [RaisesException] void overrideMimeType(DOMString mime);
     [RaisesException=Setter] attribute XMLHttpRequestResponseType responseType;
-    [Custom=Getter, RaisesException=Getter] readonly attribute object response;
-    [Custom=Getter, RaisesException=Getter] readonly attribute DOMString? responseText;
-    [RaisesException=Getter] readonly attribute Document responseXML;
+    [Custom=Getter, RaisesException=Getter] readonly attribute any response;
+    [Custom=Getter, RaisesException=Getter] readonly attribute DOMString responseText;
+    // TODO(philipj): responseXML should be [Exposed=Window].
+    [RaisesException=Getter] readonly attribute Document? responseXML;
 };