Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1167563002: Sync the XHR-related interfaces with the spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell, yhirano
CC:
blink-reviews, tyoshino+watch_chromium.org, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the XHR-related interfaces with the spec No observable changes are intended. The change to open() results in big changes to the generated code, but it should not be possible to observe the difference; the 2-argument form still treats async as true, and passing undefined for either username or password will still be converted to nullptr and then a null string. For both open() and send(), handing the default argument values in bindings allows the C++ code to be slightly simpler. Dropping [TreatReturnedNullStringAs=Undefined] for getAllResponseHeaders() makes no difference as XMLHttpRequest::getAllResponseHeaders() will never return a null string. Even when there are no headers, the untouched StringBuilder object will return an empty string from toString(), not a null string. The generated code now handles missing ProgressEventInit members, so the ProgressEvent constructor doesn't need to. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196221

Patch Set 1 #

Patch Set 2 : compile fix #

Total comments: 4

Patch Set 3 : data->body #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -78 lines) Patch
M Source/core/events/ProgressEvent.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M Source/core/events/ProgressEvent.idl View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/events/ProgressEventInit.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/FormData.idl View 3 chunks +6 lines, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 2 3 chunks +27 lines, -46 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.idl View 1 2 2 chunks +17 lines, -9 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequestEventTarget.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequestUpload.idl View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
philipj_slow
yhirano@, can you PTAL?
5 years, 6 months ago (2015-05-29 21:50:44 UTC) #2
yhirano
LGTM for core/xmlhttprequest https://codereview.chromium.org/1167563002/diff/20001/Source/core/xmlhttprequest/XMLHttpRequest.idl File Source/core/xmlhttprequest/XMLHttpRequest.idl (right): https://codereview.chromium.org/1167563002/diff/20001/Source/core/xmlhttprequest/XMLHttpRequest.idl#newcode71 Source/core/xmlhttprequest/XMLHttpRequest.idl:71: // TODO(philipj): The data argument should ...
5 years, 6 months ago (2015-06-01 01:25:12 UTC) #3
philipj_slow
https://codereview.chromium.org/1167563002/diff/20001/Source/core/xmlhttprequest/XMLHttpRequest.idl File Source/core/xmlhttprequest/XMLHttpRequest.idl (right): https://codereview.chromium.org/1167563002/diff/20001/Source/core/xmlhttprequest/XMLHttpRequest.idl#newcode71 Source/core/xmlhttprequest/XMLHttpRequest.idl:71: // TODO(philipj): The data argument should be of type ...
5 years, 6 months ago (2015-06-01 11:59:54 UTC) #4
philipj_slow
jl@, can you please review the rest of core/?
5 years, 6 months ago (2015-06-01 12:00:18 UTC) #6
Jens Widell
LGTM
5 years, 6 months ago (2015-06-01 12:16:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167563002/40001
5 years, 6 months ago (2015-06-01 12:27:55 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 13:18:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196221

Powered by Google App Engine
This is Rietveld 408576698