Source/core/layout/LayoutBlockFlow.h - Issue 1167543008: Dirty nearby lineboxes if we layout a float rather than trying to work it out later

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlockFlow.h

Issue 1167543008: Dirty nearby lineboxes if we layout a float rather than trying to work it out later (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/block/float/float-inserted-into-clean-line-expected.txt ('K') | « LayoutTests/platform/linux/fast/repaint/line-flow-with-floats-9-expected.txt ('k') | Source/core/layout/LayoutBlockFlowLine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutBlockFlow.h

diff --git a/Source/core/layout/LayoutBlockFlow.h b/Source/core/layout/LayoutBlockFlow.h

index f9333810f8f5557d0066ec3fb08dbb1efa50b50d..fb2919fff463175aa24524d10931e90f89810898 100644

--- a/Source/core/layout/LayoutBlockFlow.h

+++ b/Source/core/layout/LayoutBlockFlow.h

@@ -525,7 +525,6 @@ private:

void linkToEndLineIfNeeded(LineLayoutState&);

bool appendFloatsToEndOfLine(LineLayoutState&, bool updateFloatIndex);

static void markDirtyFloatsForPaintInvalidation(Vector<FloatWithRect>& floats);

- void checkFloatsInCleanLine(RootInlineBox*, Vector<FloatWithRect>&, size_t& floatIndex, bool& encounteredNewFloat, bool& dirtiedByFloat);

RootInlineBox* determineStartPosition(LineLayoutState&, InlineBidiResolver&);

void determineEndPosition(LineLayoutState&, RootInlineBox* startBox, InlineIterator& cleanLineStart, BidiStatus& cleanLineBidiStatus);

bool checkPaginationAndFloatsAtEndLine(LineLayoutState&);