Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1167543002: Fix checked mode error (Closed)

Created:
5 years, 6 months ago by vsm
Modified:
5 years, 6 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Filter out empty string #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M lib/src/dependency_graph.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/src/options.dart View 1 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 6 (1 generated)
vsm
https://codereview.chromium.org/1167543002/diff/1/lib/src/dependency_graph.dart File lib/src/dependency_graph.dart (right): https://codereview.chromium.org/1167543002/diff/1/lib/src/dependency_graph.dart#newcode204 lib/src/dependency_graph.dart:204: newResources.add(graph.nodeFromUri(uri.resolve(resource))); This was breaking on checked mode in angular ...
5 years, 6 months ago (2015-05-29 19:22:13 UTC) #2
vsm
Filter out empty string
5 years, 6 months ago (2015-05-29 19:29:56 UTC) #3
vsm
One more related bug https://codereview.chromium.org/1167543002/diff/20001/lib/src/options.dart File lib/src/options.dart (right): https://codereview.chromium.org/1167543002/diff/20001/lib/src/options.dart#newcode317 lib/src/options.dart:317: .toList(), Before, we had [''] ...
5 years, 6 months ago (2015-05-29 19:32:32 UTC) #4
Jennifer Messerly
lgtm
5 years, 6 months ago (2015-05-29 19:57:01 UTC) #5
vsm
5 years, 6 months ago (2015-05-29 20:18:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7c8ca4ce4038ca0e1754fd42bf16f1af32d24903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698