Issue 1167533009: Revert of ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Issue 1167533009: Revert of ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed)

Created:
5 years, 6 months ago by Nicolas Zea

Modified:
5 years, 6 months ago

Reviewers:
stuartmorgan, Sami

CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, Jackie Quinn

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (patchset #3 id:40001 of https://codereview.chromium.org/1160403005/) Reason for revert: Broke IOS_Device compile. https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/8802 Original issue's description: > ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs > > BUG=465354 > > Committed: https://crrev.com/9c8e5d7259661cda32b698ee88254491e6984900 > Cr-Commit-Position: refs/heads/master@{#333080} TBR=stuartmorgan@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=465354 Committed: https://crrev.com/64b2534aca1aae29d5d56c17396c1563d98850f8 Cr-Commit-Position: refs/heads/master@{#333083}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -60 lines)			Patch
M	ios/chrome/browser/net/retryable_url_fetcher_unittest.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ios/chrome/browser/snapshots/snapshot_cache.mm	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	ios/crnet/crnet_environment.mm	View	6 chunks	+14 lines, -12 lines	0 comments	Download
M	ios/net/cookies/cookie_store_ios.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ios/web/public/web_thread.h	View	4 chunks	+12 lines, -10 lines	0 comments	Download
M	ios/web/shell/shell_browser_state.mm	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ios/web/shell/shell_url_request_context_getter.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	ios/web/shell/shell_url_request_context_getter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ios/web/web_thread_adapter.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ios/web/web_thread_impl.cc	View	5 chunks	+19 lines, -18 lines	0 comments	Download

Total messages: 4 (0 generated)

Nicolas Zea

Created Revert of ios: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

5 years, 6 months ago (2015-06-05 17:31:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167533009/1

5 years, 6 months ago (2015-06-05 17:31:31 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 18:03:19 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/64b2534aca1aae29d5d56c17396c1563d98850f8
Cr-Commit-Position: refs/heads/master@{#333083}