Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1167533004: Move overwrite original checkbox and saved label to bottom toolbar. (Closed)

Created:
5 years, 6 months ago by yawano
Modified:
5 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move overwrite original checkbox and saved label to bottom toolbar. BUG=488227 TEST=none Committed: https://crrev.com/689d5020bb670e8c63feb20b47fedb2112eee05f Cr-Commit-Position: refs/heads/master@{#332545}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix UI in RTL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -99 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 1 9 chunks +117 lines, -76 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 1 chunk +12 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 2 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
yawano
PTAL. Thank you!
5 years, 6 months ago (2015-06-02 10:48:16 UTC) #2
mtomasz
lgtm with a nit https://codereview.chromium.org/1167533004/diff/1/ui/file_manager/gallery/css/gallery.css File ui/file_manager/gallery/css/gallery.css (right): https://codereview.chromium.org/1167533004/diff/1/ui/file_manager/gallery/css/gallery.css#newcode534 ui/file_manager/gallery/css/gallery.css:534: float: left; nit: Please confirm ...
5 years, 6 months ago (2015-06-02 10:59:20 UTC) #3
yawano
Since I've added some amount of changes to css, PTAL again. Thank you! https://codereview.chromium.org/1167533004/diff/1/ui/file_manager/gallery/css/gallery.css File ...
5 years, 6 months ago (2015-06-02 11:37:34 UTC) #4
mtomasz
lgtm!
5 years, 6 months ago (2015-06-03 03:22:10 UTC) #5
yawano
On 2015/06/03 03:22:10, mtomasz wrote: > lgtm! Thank you!
5 years, 6 months ago (2015-06-03 03:22:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167533004/20001
5 years, 6 months ago (2015-06-03 03:24:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 03:38:18 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/689d5020bb670e8c63feb20b47fedb2112eee05f Cr-Commit-Position: refs/heads/master@{#332545}
5 years, 6 months ago (2015-06-03 03:39:26 UTC) #10
yawano
5 years, 6 months ago (2015-06-10 04:11:31 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1173863004/ by yawano@chromium.org.

The reason for reverting is: All of Gallery Material Redesign will happen in
M46..

Powered by Google App Engine
This is Rietveld 408576698