Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 1167523005: Remove mutable from members in CSSSelector. (Closed)

Created:
5 years, 6 months ago by esprehn
Modified:
5 years, 6 months ago
Reviewers:
Timothy Loh, sashab, rune, ojan
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove mutable from members in CSSSelector. This was mutable from back when pseudoType() used to also compute the pseudoType and update m_match as well. Now we do that inside updatePseudoType inside the parser so we don't need mutable members. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/css/CSSSelector.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167523005/1
5 years, 6 months ago (2015-06-06 21:31:34 UTC) #2
esprehn
5 years, 6 months ago (2015-06-06 22:19:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-07 00:05:06 UTC) #6
rune
lgtm
5 years, 6 months ago (2015-06-07 21:23:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167523005/1
5 years, 6 months ago (2015-06-07 21:37:25 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-07 21:40:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196636

Powered by Google App Engine
This is Rietveld 408576698