Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1167523004: chrome/settings: Shorten strings in appearance, downloads, date&time. (Closed)

Created:
5 years, 6 months ago by James Hawkins
Modified:
5 years, 6 months ago
Reviewers:
jlklein, Jeremy Klein
CC:
chromium-reviews, asanka, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, benjhayden+dwatch_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/settings: Shorten strings in appearance, downloads, date&time. R=jlklein@chromium.org, jlklein BUG=none Committed: https://crrev.com/01cfa0ff07e349b2aeb5429782ab01e9962026ff Cr-Commit-Position: refs/heads/master@{#333068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -45 lines) Patch
M chrome/app/settings_strings.grdp View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/settings/downloads_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 2 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
James Hawkins
5 years, 6 months ago (2015-06-05 16:25:01 UTC) #1
Jeremy Klein
lgtm
5 years, 6 months ago (2015-06-05 16:26:46 UTC) #3
James Hawkins
Committed patchset #1 (id:1) manually as 01cfa0ff07e349b2aeb5429782ab01e9962026ff (presubmit successful).
5 years, 6 months ago (2015-06-05 16:50:16 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:50:18 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/01cfa0ff07e349b2aeb5429782ab01e9962026ff
Cr-Commit-Position: refs/heads/master@{#333068}

Powered by Google App Engine
This is Rietveld 408576698