Issue 1167513003: Make --gdb and gdb_attach mostly work in shelldb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1167513003: Make --gdb and gdb_attach mostly work in shelldb (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
iansf, jackson

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org, iansf

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make --gdb and gdb_attach mostly work in shelldb I'm not sure this is 100% working, but hopefully this will help get jackson@ up and running with a shelldb workflow. R=iansf@google.com, jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e032785f69ff85e2894b89e0a7d9fa271390064c

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -4 lines)			Patch
	M	sky/tools/shelldb	View	1	7 chunks	+153 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

jackson

lgtm could probably use some cleanup but this works for me

5 years, 6 months ago (2015-05-29 19:24:43 UTC) #2

iansf

If this is working, then we probably want to add a ticket to refactor this ...

5 years, 6 months ago (2015-05-29 19:25:43 UTC) #4

eseidel

5 years, 6 months ago (2015-05-29 19:31:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e032785f69ff85e2894b89e0a7d9fa271390064c (presubmit successful).