Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1167503002: Remove obsolete pinch-zoom related code. (Closed)

Created:
4 years, 11 months ago by bokan
Modified:
4 years, 11 months ago
Reviewers:
pdr.
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove obsolete pinch-zoom related code. Removing some left over bits of code from the old path of pinch-zoom: setMainFrameScrollOffset from the Blink public API - this is only used within Blink internally. Remove obsolete dead code from PinchViewport::setScaleAndLocation - forgot to remove this when tearing out old path in r192391.. Remove VirtualViewport setting from WebSettings - now that the Chromium side is removed, this is no longer needed. BUG=304869 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196313

Patch Set 1 #

Patch Set 2 : Fix for broken SVG layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -32 lines) Patch
M Source/core/frame/PinchViewport.cpp View 1 1 chunk +3 lines, -13 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/web/WebView.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
bokan
Hi PDR, bit of cleanup, ptal.
4 years, 11 months ago (2015-05-29 13:39:43 UTC) #2
pdr.
On 2015/05/29 at 13:39:43, bokan wrote: > Hi PDR, bit of cleanup, ptal. LGTM
4 years, 11 months ago (2015-05-29 18:14:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167503002/1
4 years, 11 months ago (2015-05-29 18:14:54 UTC) #5
bokan
There's one svg layout test that was causing a crash with my change, looks like ...
4 years, 11 months ago (2015-05-29 19:18:22 UTC) #6
bokan
ping
4 years, 11 months ago (2015-06-01 18:45:01 UTC) #7
pdr.
LGTM
4 years, 11 months ago (2015-06-01 22:19:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167503002/20001
4 years, 11 months ago (2015-06-02 10:35:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64399)
4 years, 11 months ago (2015-06-02 12:32:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167503002/20001
4 years, 11 months ago (2015-06-02 13:15:51 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 14:01:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196313

Powered by Google App Engine
This is Rietveld 408576698