Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 11675002: Popup for html select tag doesn't close properly (Closed)

Created:
7 years, 12 months ago by sschmitz
Modified:
7 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Solution: the popup keeps mouse capture, so that any mouse click closes it (via WebKit's WebPopupMenuImpl.cpp) not just clicks in it or in its browser window. BUG=161129 TEST=navigate to http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select Click on the "car name" to bring up the pop-up. Click outside the browser window to see it close (just as for clicking inside the browser window) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175644

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +6 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
sschmitz
7 years, 12 months ago (2012-12-26 22:48:24 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/11675002/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/11675002/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1550 content/browser/renderer_host/render_widget_host_view_aura.cc:1550: (popup_child_host_view_ == NULL || !popup_child_host_view_
7 years, 11 months ago (2013-01-08 20:48:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/11675002/1
7 years, 11 months ago (2013-01-08 21:15:25 UTC) #3
commit-bot: I haz the power
Change committed as 175644
7 years, 11 months ago (2013-01-09 00:39:22 UTC) #4
Nikita (slow)
7 years, 11 months ago (2013-01-10 10:58:16 UTC) #5
Message was sent while issue was closed.
Since this caused a P1 regression like
http://code.google.com/p/chromium/issues/detail?id=169113 it would make sense to
have some kind of a regression test.

Powered by Google App Engine
This is Rietveld 408576698