Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 1167473002: Also expose DefineOwnProperty (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
Reviewers:
adamk, Toon Verwaest
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Also expose DefineOwnProperty In contrast to CreateDataProperty, this will always call out to JS BUG=475206 R=adamk@chromium.org,verwaest@chromium.org LOG=y Committed: https://crrev.com/4b548dd15a750ed28f4517280576e06fd4efc4fd Cr-Commit-Position: refs/heads/master@{#28712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -22 lines) Patch
M include/v8.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +35 lines, -9 lines 0 comments Download
M src/v8natives.js View 4 chunks +13 lines, -13 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-05-29 08:35:53 UTC) #1
adamk
lgtm
5 years, 6 months ago (2015-05-29 17:03:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167473002/1
5 years, 6 months ago (2015-06-01 07:01:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 07:26:43 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 07:26:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b548dd15a750ed28f4517280576e06fd4efc4fd
Cr-Commit-Position: refs/heads/master@{#28712}

Powered by Google App Engine
This is Rietveld 408576698