Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: extensions/renderer/module_system_test.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/module_system_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/module_system_test.h" 5 #include "extensions/renderer/module_system_test.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/files/file_util.h" 12 #include "base/files/file_util.h"
13 #include "base/lazy_instance.h" 13 #include "base/lazy_instance.h"
14 #include "base/memory/scoped_ptr.h" 14 #include "base/memory/scoped_ptr.h"
15 #include "base/path_service.h" 15 #include "base/path_service.h"
16 #include "base/stl_util.h" 16 #include "base/stl_util.h"
17 #include "base/strings/string_piece.h" 17 #include "base/strings/string_piece.h"
18 #include "extensions/common/extension_paths.h" 18 #include "extensions/common/extension_paths.h"
19 #include "extensions/renderer/logging_native_handler.h" 19 #include "extensions/renderer/logging_native_handler.h"
20 #include "extensions/renderer/object_backed_native_handler.h" 20 #include "extensions/renderer/object_backed_native_handler.h"
21 #include "extensions/renderer/safe_builtins.h" 21 #include "extensions/renderer/safe_builtins.h"
22 #include "extensions/renderer/utils_native_handler.h" 22 #include "extensions/renderer/utils_native_handler.h"
23 #include "ui/base/resource/resource_bundle.h" 23 #include "ui/base/resource/resource_bundle.h"
24 24
25 namespace extensions { 25 namespace extensions {
26 namespace { 26 namespace {
27 27
28 class FailsOnException : public ModuleSystem::ExceptionHandler { 28 class FailsOnException : public ModuleSystem::ExceptionHandler {
29 public: 29 public:
30 FailsOnException() : ModuleSystem::ExceptionHandler(NULL) {}
30 void HandleUncaughtException(const v8::TryCatch& try_catch) override { 31 void HandleUncaughtException(const v8::TryCatch& try_catch) override {
31 FAIL() << "Uncaught exception: " << CreateExceptionString(try_catch); 32 FAIL() << "Uncaught exception: "
33 << CreateExceptionString(try_catch);
32 } 34 }
33 }; 35 };
34 36
35 class V8ExtensionConfigurator { 37 class V8ExtensionConfigurator {
36 public: 38 public:
37 V8ExtensionConfigurator() 39 V8ExtensionConfigurator()
38 : safe_builtins_(SafeBuiltins::CreateV8Extension()), 40 : safe_builtins_(SafeBuiltins::CreateV8Extension()),
39 names_(1, safe_builtins_->name()), 41 names_(1, safe_builtins_->name()),
40 configuration_( 42 configuration_(
41 new v8::ExtensionConfiguration(static_cast<int>(names_.size()), 43 new v8::ExtensionConfiguration(static_cast<int>(names_.size()),
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 249
248 void ModuleSystemTest::ExpectNoAssertionsMade() { 250 void ModuleSystemTest::ExpectNoAssertionsMade() {
249 should_assertions_be_made_ = false; 251 should_assertions_be_made_ = false;
250 } 252 }
251 253
252 void ModuleSystemTest::RunResolvedPromises() { 254 void ModuleSystemTest::RunResolvedPromises() {
253 isolate_->RunMicrotasks(); 255 isolate_->RunMicrotasks();
254 } 256 }
255 257
256 } // namespace extensions 258 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/module_system_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698