Add blob scheme in Navigation Histograms

Add blob scheme in Navigation Histograms

Added 'blob' scheme in Navigation.MainFrameScheme and Navigation.MainFrameSchemeDifferentPage histograms.
Added it in the end, before the scheme_max so that scheme_max contains the number of schemes.

BUG=492773
Committed: https://crrev.com/871c0d15c5ad16b9e8e101cbdb5ea0415674d86f
Cr-Commit-Position: refs/heads/master@{#333665}

[Bhanu Dev, 2015-06-09 00:21:38]

bhanudev@google.com changed reviewers:
+ meacer@chromium.org

[meacer, 2015-06-09 00:27:11]

You should change the bug number to point to the bug (BUG= field).
You might also want to spell out the full histogram name in the "subject" line,
such as "Add blob scheme to the Navigation.MainFrameScheme" histogram".

[meacer, 2015-06-09 00:46:50]

LGTM

[Bhanu Dev, 2015-06-09 00:50:22]

bhanudev@google.com changed reviewers:
+ cbentzel@chromium.org

[Bhanu Dev, 2015-06-09 01:07:41]

On 2015/06/09 00:46:50, Mustafa Emre Acer wrote:
> LGTM

+cbentzel, for owners review, ptal? Thanks.

[cbentzel, 2015-06-09 09:09:48]

LGTM

On Mon, Jun 8, 2015 at 9:07 PM <bhanudev@google.com> wrote:

> Reviewers: Mustafa Emre Acer, cbentzel,
>
> Message:
> On 2015/06/09 00:46:50, Mustafa Emre Acer wrote:
> > LGTM
>
> +cbentzel, for owners review, ptal? Thanks.
>
> Description:
> Add blob scheme in Navigation Histograms
>
> Added 'blob' scheme in Navigation.MainFrameScheme and
> Navigation.MainFrameSchemeDifferentPage histograms.
> Added it in the end, before the scheme_max so that scheme_max contains the
> number of schemes.
>
> BUG=492773
>
> Please review this at https://codereview.chromium.org/1167403002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+3, -0 lines):
>    M components/navigation_metrics/navigation_metrics.cc
>    M tools/metrics/histograms/histograms.xml
>
>
> Index: components/navigation_metrics/navigation_metrics.cc
> diff --git a/components/navigation_metrics/navigation_metrics.cc
> b/components/navigation_metrics/navigation_metrics.cc
> index
>
>
214c75fc1d2c60adc9657631ee65c462555d9bf5..cf72ce45313d7b4fc7ed7bd62aec5d70e59518c0
> 100644
> --- a/components/navigation_metrics/navigation_metrics.cc
> +++ b/components/navigation_metrics/navigation_metrics.cc
> @@ -19,6 +19,7 @@ enum Scheme {
>     SCHEME_JAVASCRIPT,
>     SCHEME_ABOUT,
>     SCHEME_CHROME,
> +  SCHEME_BLOB,
>     SCHEME_MAX,
>   };
>
> @@ -32,6 +33,7 @@ const char* const kSchemeNames[] = {
>     url::kJavaScriptScheme,
>     url::kAboutScheme,
>     "chrome",
> +  url::kBlobScheme,
>     "max",
>   };
>
> Index: tools/metrics/histograms/histograms.xml
> diff --git a/tools/metrics/histograms/histograms.xml
> b/tools/metrics/histograms/histograms.xml
> index
>
>
c23dc084db689b42598b120d28b67460e0425a89..3d1fe204d18f8672ab262bfbd2ae5b81d2d52fb2
> 100644
> --- a/tools/metrics/histograms/histograms.xml
> +++ b/tools/metrics/histograms/histograms.xml
> @@ -60063,6 +60063,7 @@ To add a new entry, add it with any value and run
> test to compute valid value.
>     <int value="6" label="javascript"/>
>     <int value="7" label="about"/>
>     <int value="8" label="chrome"/>
> +  <int value="9" label="blob"/>
>   </enum>
>
>   <enum name="NetCacheState" type="int">
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cbentzel, 2015-06-09 09:10:07]

lgtm

[Bhanu Dev, 2015-06-09 17:09:54]

The CQ bit was checked by bhanudev@google.com

[Bhanu Dev, 2015-06-09 17:09:55]

The CQ bit was unchecked by bhanudev@google.com

[Bhanu Dev, 2015-06-09 17:14:37]

The CQ bit was unchecked by bhanudev@google.com

[Bhanu Dev, 2015-06-09 17:14:38]

The CQ bit was checked by bhanudev@google.com

[Bhanu Dev, 2015-06-09 17:14:50]

The CQ bit was checked by bhanudev@google.com

[commit-bot: I haz the power, 2015-06-09 17:14:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167403002/20001

[commit-bot: I haz the power, 2015-06-09 17:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 17:22:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bhanu Dev, 2015-06-09 17:37:20]

bhanudev@google.com changed reviewers:
+ isherman@chromium.org

[Bhanu Dev, 2015-06-09 17:40:22]

On 2015/06/09 17:22:08, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

I am sorry. I did not get LGTM from the owner of */histograms.xml file.

+isherman, for owners review, ptal? Thanks.

[Ilya Sherman, 2015-06-09 19:53:36]

LGTM w/ a comment:

https://codereview.chromium.org/1167403002/diff/20001/components/navigation_m...
File components/navigation_metrics/navigation_metrics.cc (right):

https://codereview.chromium.org/1167403002/diff/20001/components/navigation_m...
components/navigation_metrics/navigation_metrics.cc:12: enum Scheme {
Please add documentation to indicate that this enum is used to back a histogram,
and should therefore be treated as append-only.

[Bhanu Dev, 2015-06-10 00:27:49]

The CQ bit was checked by bhanudev@google.com

[Bhanu Dev, 2015-06-10 00:27:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbentzel@chromium.org, isherman@chromium.org, meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/1167403002/#ps40001
(title: "Documented that the scheme enum is append only")

[Bhanu Dev, 2015-06-10 00:29:02]

Added 'blob' scheme in Navigation.MainFrameScheme and
Navigation.MainFrameSchemeDifferentPage histograms.
Added a comment stating that enum is used in computing histogram, so it is
append-only. Thanks.

https://codereview.chromium.org/1167403002/diff/20001/components/navigation_m...
File components/navigation_metrics/navigation_metrics.cc (right):

https://codereview.chromium.org/1167403002/diff/20001/components/navigation_m...
components/navigation_metrics/navigation_metrics.cc:12: enum Scheme {
On 2015/06/09 19:53:36, Ilya Sherman wrote:
> Please add documentation to indicate that this enum is used to back a
histogram,
> and should therefore be treated as append-only.

Done.

[Bhanu Dev, 2015-06-10 00:30:52]

The CQ bit was unchecked by bhanudev@google.com

[Bhanu Dev, 2015-06-10 00:30:52]

The CQ bit was checked by bhanudev@google.com

[commit-bot: I haz the power, 2015-06-10 00:31:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167403002/40001

[commit-bot: I haz the power, 2015-06-10 02:51:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 02:52:22]

Patchset 3 (id:??) landed as
https://crrev.com/871c0d15c5ad16b9e8e101cbdb5ea0415674d86f
Cr-Commit-Position: refs/heads/master@{#333665}