PDF: Interpret printing permission bits correctly.

PDF: Interpret printing permission bits correctly.

The rules for interpreting printing permission bits are different
depending on the security handler revision. This takes the handler
revision into account.

BUG=497924
Committed: https://crrev.com/b9357a7d2361b9f03e5a0a4ee784016adcea5303
Cr-Commit-Position: refs/heads/master@{#333864}

[Lei Zhang, 2015-06-08 23:50:46]

thestig@chromium.org changed reviewers:
+ raymes@chromium.org

[Lei Zhang, 2015-06-08 23:50:46]

I tested the PDF provided by the bug reporter and it now reports high fidelity
instead of low.

[raymes, 2015-06-09 00:32:59]

https://codereview.chromium.org/1167393002/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1167393002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:2327: bool
PDFiumEngine::HasPermission(DocumentPermission permission) const {
Is it worth checking that this is not -1?

https://codereview.chromium.org/1167393002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:2350: case PERMISSION_PRINT_HIGH_QUALITY:
So I guess that if the revision is <3 then you only need the low quality bit in
order to print at high quality? Is that true? It might be worth making a note of
that here and also above in the revision >=3 branch

[Lei Zhang, 2015-06-09 00:39:41]

https://codereview.chromium.org/1167393002/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1167393002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:2327: bool
PDFiumEngine::HasPermission(DocumentPermission permission) const {
On 2015/06/09 00:32:59, raymes wrote:
> Is it worth checking that this is not -1?

I'm interpreting -1 as unknown and treating it as "we are not respecting any
permission bits", so it fits with the < 2 comparison.

https://codereview.chromium.org/1167393002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:2350: case PERMISSION_PRINT_HIGH_QUALITY:
On 2015/06/09 00:32:59, raymes wrote:
> So I guess that if the revision is <3 then you only need the low quality bit
in
> order to print at high quality? Is that true? It might be worth making a note
of
> that here and also above in the revision >=3 branch

Sure.

[Lei Zhang, 2015-06-09 18:40:33]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-09 18:41:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167393002/20001

[commit-bot: I haz the power, 2015-06-09 19:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 19:24:55]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2015-06-10 21:48:27]

ping

[raymes, 2015-06-11 00:02:20]

lgtm 

Sorry for the delay!

[Lei Zhang, 2015-06-11 00:02:54]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-06-11 00:04:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167393002/20001

[commit-bot: I haz the power, 2015-06-11 00:53:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-11 00:54:04]

Patchset 2 (id:??) landed as
https://crrev.com/b9357a7d2361b9f03e5a0a4ee784016adcea5303
Cr-Commit-Position: refs/heads/master@{#333864}