Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1167343004: Update config names for WebRTC extended filter echo cancellation (Closed)

Created:
5 years, 6 months ago by hlundin-chromium
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update config names for WebRTC extended filter echo cancellation This change switches from the old config and constraint names (DelayCorrection and kExperimentalEchoCancellation) to the new ones (ExtendedFilter and kExtendedFilterEchoCancellation). The old names are deprecated in WebRTC and will be removed. BUG=webrtc:4696 Committed: https://crrev.com/08e7b741d616e1f155bb6c02332fffc50b7bbaa5 Cr-Commit-Position: refs/heads/master@{#333933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/media/media_stream_audio_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_constraint_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167343004/1
5 years, 6 months ago (2015-06-10 12:57:39 UTC) #4
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
5 years, 6 months ago (2015-06-10 12:57:42 UTC) #6
hlundin-chromium
tommi, ajm, Please, take a look. Thanks!
5 years, 6 months ago (2015-06-10 12:57:56 UTC) #7
ajm
lgtm
5 years, 6 months ago (2015-06-10 16:41:06 UTC) #8
tommi (sloooow) - chröme
lgtm
5 years, 6 months ago (2015-06-11 11:17:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167343004/1
5 years, 6 months ago (2015-06-11 11:21:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 12:17:30 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 12:18:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08e7b741d616e1f155bb6c02332fffc50b7bbaa5
Cr-Commit-Position: refs/heads/master@{#333933}

Powered by Google App Engine
This is Rietveld 408576698