third_party/WebKit/Source/bindings/core/v8/ScriptValue.h - Issue 1167343002: Add methods for creating V8 extras-based ReadableStreams from C++

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

Issue 1167343002: Add methods for creating V8 extras-based ReadableStreams from C++ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Trying blindly to resolve circular dependency Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ToV8.h » ('j') | third_party/WebKit/Source/bindings/core/v8/ToV8.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h b/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

index 539bf11f607f1e40e21d2b69590360cac49a4d1f..06b5c254982ceaab349d78c22cc3ed82d12d3838 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

@@ -45,11 +45,9 @@ namespace blink {

class CORE_EXPORT ScriptValue final {

DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();

public:

+ // Defined in ToV8.h due to circular dependency

template<typename T>

- static ScriptValue from(ScriptState* scriptState, T value)

- {

- return ScriptValue(scriptState, toV8(value, scriptState->context()->Global(), scriptState->isolate()));

- }

+ static ScriptValue from(ScriptState*, T&& value);

template<typename T, typename... Arguments>

static inline T to(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState, Arguments const&... arguments)