Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp

Issue 1167343002: Add methods for creating V8 extras-based ReadableStreams from C++ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Don't modify UnderlyingSource.h, oops Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp
index 707fba14451e5c246bde9f95c7f89375631d7c0d..656876e27b06a4590190875dc7cae76eaf415b67 100644
--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp
+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp
@@ -132,7 +132,7 @@ public:
RefPtr<ReadingContext> m_readingContext;
};
- static PassRefPtr<ReadingContext> create(ScriptState* scriptState, v8::Local<v8::Value> stream)
+ static PassRefPtr<ReadingContext> create(ScriptState* scriptState, ScriptValue stream)
{
return adoptRef(new ReadingContext(scriptState, stream));
}
@@ -169,9 +169,7 @@ public:
m_isReading = true;
ScriptState::Scope scope(m_reader.scriptState());
V8RecursionScope recursionScope(m_reader.isolate());
- ReadableStreamOperations::read(m_reader.scriptState(), m_reader.v8Value()).then(
- OnFulfilled::createFunction(m_reader.scriptState(), m_weakPtrFactory.createWeakPtr()),
- OnRejected::createFunction(m_reader.scriptState(), m_weakPtrFactory.createWeakPtr()));
+ ReadableStreamOperations::read(m_reader.scriptState(), m_reader).then(OnFulfilled::createFunction(m_reader.scriptState(), m_weakPtrFactory.createWeakPtr()), OnRejected::createFunction(m_reader.scriptState(), m_weakPtrFactory.createWeakPtr()));
// Note: Microtasks may run here.
}
m_isInRecursion = false;
@@ -239,7 +237,7 @@ public:
}
private:
- ReadingContext(ScriptState* scriptState, v8::Local<v8::Value> stream)
+ ReadingContext(ScriptState* scriptState, ScriptValue stream)
: m_client(nullptr)
, m_weakPtrFactory(this)
, m_pendingOffset(0)
@@ -273,7 +271,7 @@ private:
bool m_isInRecursion;
};
-ReadableStreamDataConsumerHandle::ReadableStreamDataConsumerHandle(ScriptState* scriptState, v8::Local<v8::Value> stream)
+ReadableStreamDataConsumerHandle::ReadableStreamDataConsumerHandle(ScriptState* scriptState, ScriptValue stream)
: m_readingContext(ReadingContext::create(scriptState, stream))
{
}

Powered by Google App Engine
This is Rietveld 408576698