Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: Source/web/tests/WebPageNewSerializerTest.cpp

Issue 1167313002: Merge page serializers [3/12] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | Source/web/tests/data/pageserializer/green_rectangle.svg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebPageNewSerializerTest.cpp
diff --git a/Source/web/tests/WebPageNewSerializerTest.cpp b/Source/web/tests/WebPageNewSerializerTest.cpp
index bc224ddddeac92903fcbde84b8dfbf1c486a935b..d0142f3e7e8b887f5a87c0fd7bf13949f66dc2b8 100644
--- a/Source/web/tests/WebPageNewSerializerTest.cpp
+++ b/Source/web/tests/WebPageNewSerializerTest.cpp
@@ -363,46 +363,6 @@ TEST_F(WebPageNewSerializeTest, FAILS_TestMHTMLEncoding)
EXPECT_EQ(12, sectionCheckedCount);
}
-// Test that we don't regress https://bugs.webkit.org/show_bug.cgi?id=99105
-TEST_F(WebPageNewSerializeTest, SVGImageDontCrash)
-{
- WebURL pageUrl = toKURL(m_baseURL);
- WebURL imageUrl = toTestURL("green_rectangle.svg");
-
- registerMockedURLLoad(pageUrl, WebString::fromUTF8("page_with_svg_image.html"), WebString::fromUTF8("pageserializer/"), htmlMimeType());
- registerMockedURLLoad(imageUrl, WebString::fromUTF8("green_rectangle.svg"), WebString::fromUTF8("pageserializer/"), svgMimeType());
-
- loadURLInTopFrame(pageUrl);
-
- WebCString mhtml = WebPageSerializer::serializeToMHTML(webView());
- // We expect some data to be generated.
- EXPECT_GT(mhtml.length(), 50U);
-}
-
-
-TEST_F(WebPageNewSerializeTest, NamespaceElementsDontCrash)
-{
- WebURL pageUrl = toKURL(m_baseURL);
- registerMockedURLLoad(pageUrl, WebString::fromUTF8("namespace_element.html"), WebString::fromUTF8("pageserializer/"), htmlMimeType());
-
- loadURLInTopFrame(pageUrl);
-
- WebVector<WebURL> localLinks(static_cast<size_t>(1));
- WebVector<WebString> localPaths(static_cast<size_t>(1));
- localLinks[0] = pageUrl;
- localPaths[0] = WebString("/");
-
- size_t counter = 0;
- LengthCountingWebPageSerializerClient client(&counter);
-
- // We just want to make sure nothing crazy happens, namely that no
- // assertions are hit. As a sanity check, we also make sure that some data
- // was returned.
- WebPageSerializer::serialize(webView()->mainFrame()->toWebLocalFrame(), true, &client, localLinks, localPaths, WebString(""));
-
- EXPECT_GT(counter, 0U);
-}
-
TEST_F(WebPageNewSerializeTest, SubFrameSerialization)
{
WebURL pageUrl = toKURL(m_baseURL);
« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | Source/web/tests/data/pageserializer/green_rectangle.svg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698