Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: Source/web/tests/PageSerializerTest.cpp

Issue 1167313002: Merge page serializers [3/12] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/PageSerializerTest.cpp
diff --git a/Source/web/tests/PageSerializerTest.cpp b/Source/web/tests/PageSerializerTest.cpp
index dc5d0cbfccb2f5b5040b71ecdda3646d64de3338..61cb0140c1621b6d72006684d39a5ce901d3d15f 100644
--- a/Source/web/tests/PageSerializerTest.cpp
+++ b/Source/web/tests/PageSerializerTest.cpp
@@ -244,6 +244,22 @@ TEST_F(PageSerializerTest, DataURIMorphing)
EXPECT_TRUE(isSerialized("page_with_morphing_data.html", "text/html"));
}
+// Test that we don't regress https://bugs.webkit.org/show_bug.cgi?id=99105
+TEST_F(PageSerializerTest, SVGImageDontCrash)
+{
+ setBaseFolder("pageserializer/svg/");
+
+ registerURL("page_with_svg_image.html", "text/html");
+ registerURL("green_rectangle.svg", "image/svg+xml");
+
+ serialize("page_with_svg_image.html");
+
+ EXPECT_EQ(2U, getResources().size());
+
+ EXPECT_TRUE(isSerialized("green_rectangle.svg", "image/svg+xml"));
+ EXPECT_GT(getSerializedData("green_rectangle.svg", "image/svg+xml").length(), 250U);
+}
+
TEST_F(PageSerializerTest, DontIncludeErrorImage)
{
setBaseFolder("pageserializer/image/");
@@ -258,4 +274,17 @@ TEST_F(PageSerializerTest, DontIncludeErrorImage)
EXPECT_FALSE(isSerialized("error_image.png", "image/png"));
}
+TEST_F(PageSerializerTest, NamespaceElementsDontCrash)
+{
+ setBaseFolder("pageserializer/namespace/");
+
+ registerURL("namespace_element.html", "text/html");
+
+ serialize("namespace_element.html");
+
+ EXPECT_EQ(1U, getResources().size());
+ EXPECT_TRUE(isSerialized("namespace_element.html", "text/html"));
+ EXPECT_GT(getSerializedData("namespace_element.html", "text/html").length(), 0U);
+}
+
}
« no previous file with comments | « no previous file | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698