chrome/browser/ui/views/download/download_shelf_view.cc - Issue 11673004: No need to pass DownloadItemModel ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_shelf_view.cc

Issue 11673004: No need to pass DownloadItemModel ownership. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: DownloadShelfContextMenu class cleanup and require GetMenuModel() to return non-NULL Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/download/download_shelf_view.cc

diff --git a/chrome/browser/ui/views/download/download_shelf_view.cc b/chrome/browser/ui/views/download/download_shelf_view.cc

index 99a060c5bf711f59a8415c3e3e8a80fd07f39d73..22af3587172c41844471c6e2e7368bfce7bc7e0b 100644

--- a/chrome/browser/ui/views/download/download_shelf_view.cc

+++ b/chrome/browser/ui/views/download/download_shelf_view.cc

@@ -120,9 +120,8 @@ void DownloadShelfView::AddDownloadView(DownloadItemView* view) {

new_item_animation_->Show();

}

-void DownloadShelfView::DoAddDownload(DownloadItemModel* download_model) {

- DownloadItemView* view = new DownloadItemView(

- download_model->download(), this, download_model);

+void DownloadShelfView::DoAddDownload(DownloadItem* download) {

+ DownloadItemView* view = new DownloadItemView(download, this);

AddDownloadView(view);

}

« no previous file with comments | « chrome/browser/ui/views/download/download_shelf_view.h ('k') | no next file » | no next file with comments »