chrome/browser/ui/cocoa/download/download_shelf_mac.mm - Issue 11673004: No need to pass DownloadItemModel ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_mac.mm

Issue 11673004: No need to pass DownloadItemModel ownership. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: DownloadShelfContextMenu class cleanup and require GetMenuModel() to return non-NULL Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/download/download_shelf_mac.mm

diff --git a/chrome/browser/ui/cocoa/download/download_shelf_mac.mm b/chrome/browser/ui/cocoa/download/download_shelf_mac.mm

index fe4ed360e281fed879324bac1ab80891d748fde3..c644b51927b12346f08f61722b477d7ac36773ab 100644

--- a/chrome/browser/ui/cocoa/download/download_shelf_mac.mm

+++ b/chrome/browser/ui/cocoa/download/download_shelf_mac.mm

@@ -15,8 +15,8 @@ DownloadShelfMac::DownloadShelfMac(Browser* browser,

shelf_controller_(controller) {

}

-void DownloadShelfMac::DoAddDownload(DownloadItemModel* download_model) {

- [shelf_controller_ addDownloadItem:download_model];

+void DownloadShelfMac::DoAddDownload(content::DownloadItem* download) {

+ [shelf_controller_ addDownloadItem:download];

}

bool DownloadShelfMac::IsShowing() const {