Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(254)

Issue 1167293004: [SP] Always anti-alias borders (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, reed1, robertphillips, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[SP] Always anti-alias borders When slimming paint is enabled, skip the CTM dependent heuristic and always anti-alias borders. This relies on heavy use of overdraw, which is now applicable in most cases thanks to the recent BoxBorderPainter changes. BUG=474265 R=chrishtr@chromium.org,fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196779

Patch Set 1 #

Patch Set 2 : s/mitre/miter/g #

Patch Set 3 : expectations #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -51 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 chunks +78 lines, -2 lines 0 comments Download
M Source/core/paint/BoxBorderPainter.h View 1 2 chunks +7 lines, -7 lines 1 comment Download
M Source/core/paint/BoxBorderPainter.cpp View 1 9 chunks +42 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
f(malita)
After all the BoxBorderPainter massaging, we can finally flip the switch on AA borders without ...
4 years, 10 months ago (2015-06-09 14:13:32 UTC) #1
fs
LGTM, especially the re -> er bit! =D
4 years, 10 months ago (2015-06-09 15:52:08 UTC) #2
chrishtr
lgtm https://codereview.chromium.org/1167293004/diff/40001/Source/core/paint/BoxBorderPainter.h File Source/core/paint/BoxBorderPainter.h (left): https://codereview.chromium.org/1167293004/diff/40001/Source/core/paint/BoxBorderPainter.h#oldcode31 Source/core/paint/BoxBorderPainter.h:31: enum MitreType { American English FTW!
4 years, 10 months ago (2015-06-09 16:30:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167293004/40001
4 years, 10 months ago (2015-06-09 16:31:10 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 16:35:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196779

Powered by Google App Engine
This is Rietveld 408576698