Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 1167263002: Oilpan: constrain run-time verification of eager finalization. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: constrain run-time verification of eager finalization. Do not verify eager finalization of a class outside of ENABLE(OILPAN), as some of the classes marked as eagerly finalizing will not be on the Oilpan heap with !ENABLE(OILPAN). R= BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/heap/Heap.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. Turn off the run-time verification with !ENABLE(OILPAN), as it fails (as ...
5 years, 6 months ago (2015-06-08 20:57:42 UTC) #2
sof
If acceptable, please land this overnight (my time), as we can then move forward with ...
5 years, 6 months ago (2015-06-08 20:59:10 UTC) #3
haraken
LGTM It seems better to create a way to check if a given object is ...
5 years, 6 months ago (2015-06-08 23:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167263002/1
5 years, 6 months ago (2015-06-08 23:46:54 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 00:46:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196718

Powered by Google App Engine
This is Rietveld 408576698