Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1167233002: split analyze and format steps out of test.sh (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

split analyze and format steps out of test.sh presubmit.sh still runs all of them in the same order often I'd like to iterate on analyze or rerun format without running all of the tests, and find myself copying analyze or format lines from test.sh R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a010488014463c055234961742fc3031e69f3b74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
A tool/analyze.sh View 1 chunk +14 lines, -0 lines 0 comments Download
A tool/format.sh View 1 chunk +16 lines, -0 lines 0 comments Download
M tool/presubmit.sh View 1 chunk +2 lines, -0 lines 0 comments Download
M tool/test.sh View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
Travis results https://travis-ci.org/dart-lang/dev_compiler/jobs/65950573
5 years, 6 months ago (2015-06-08 20:31:02 UTC) #2
Leaf
Awesome, I've been wanting this! LGTM
5 years, 6 months ago (2015-06-08 20:38:34 UTC) #3
Jennifer Messerly
5 years, 6 months ago (2015-06-08 20:48:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a010488014463c055234961742fc3031e69f3b74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698