[Android] Add a tool for application update verification.

[Android] Add a tool for application update verification.

Usage: run_update_verification.py [options]

Performs semi-automated application update verification testing. When given
--save, it takes a snapshot of the application data on the device. (A dialog
on the device will prompt the user to grant permission to backup the data.)
Otherwise, it performs the update testing as follows: 1. Installs the |from-
apk|. 2. Restores the previously stored snapshot of application data given by
|app-data|. (A dialog on the device will prompt the user to grant permission
to restore the data.) 3. Verifies that |to-apk| cannot be installed side-by-
side. 4. Verifying that |to-apk| can replace |from-apk|.

Options:
  -h, --help            show this help message and exit
  --package-name=PACKAGE_NAME
                        Package name for the application.
  --save                Save a snapshot of application data. This will be
                        saved as backup.db in the current directory.
  --from-apk=FROM_APK   APK to update from.
  --to-apk=TO_APK       APK to update to.
  --app-data=APP_DATA   Path to the previously stored application data

BUG=167778
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176218

[frankf, 2012-12-28 00:45:35]

@christine: Feel free to play with this before it lands and provide feedback on
functionality or interface.

[Isaac (away), 2012-12-28 02:05:13]

Could we move this to test/android instead of build/android?  Are you intending
to add this as a build step for buildbot?  Please file a bug for this change and
add a BUG= line if one does not already exist.

[frankf, 2012-12-28 18:38:09]

Create a bug.

I also created crbug.com/167779 to figure out where to put the test scripts
which is a larger effort. It doesn't make sense to move this as a one-off.

On 2012/12/28 02:05:13, Isaac wrote:
> Could we move this to test/android instead of build/android?  Are you
intending
> to add this as a build step for buildbot?

No, this is semi-automated as stated.

  Please file a bug for this change and
> add a BUG= line if one does not already exist.

[frankf, 2012-12-28 18:38:55]

+craigdh

[klundberg, 2013-01-02 17:23:40]

I agree with Isaac that this shouldn't be in build/android.
And I think it would be best to find the right location for it before submitting
this, especially as this is a pretty self-containing test script.

Also, please make sure that Christine runs this and provides feedback before
submitting.

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
File build/android/run_update_verification.py (right):

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:24: logging.info('Installing %s...',
from_apk)
Seems like it should be possible to call _SaveAppData without installing the
APK. For example, if a tester has been doing manual testing of the previous
version  on a given device and already has lots of app data, there is really no
need to install the APK.

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:29: raw_input('Set the application
sate. Once ready, press enter and '
sate/state

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:36: assert os.path.exists(app_data),
'Backup file doesn not exist!'
doesn not/does not

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:89: 'current directory.'))
How about making it possible to specify the file where you store the data? That
would make it easier to provide the --app-data argument when running this for 
update testing.

[craigdh, 2013-01-02 18:26:20]

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
File build/android/run_update_verification.py (right):

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:118: assert
os.path.exists(options.from_apk)
os.path.isfile instead?

[klundberg, 2013-01-08 20:45:13]

I downloaded the patch and tried running the tool. I discussed some of these
comment with Frank in person but want to capture them all here.

1. It would be great to not have to specify from-apk when saving the application
data. If I already have an APK installed with useful data, I just want to save
the data, not have to get the APK on my desktop to install it.

2. Similar for updating. If the APK is already installed, I don't want to have
to get the APK on my desktop just to over-install with the same APK.

3. It would be nice to be able to specify where the data is saved. I ran the
tool from my clankium/src folder and really don't want to make my tree dirty
with "random" files.

4. Is it necessary to always specify the package name? Just wondering if you can
provide default for that as well to make it as easy as possible to run this.

Otherwise, I think this is great and I would really like to get Christine's
opinion on this.

[frankf, 2013-01-10 23:15:05]

Talked to Karin offline, testing/android is not suitable for such script right.
So, let's put it here, and address it as part of refactoring.

About --package-name: I thought about accepting channel names and mapping them
to package names, but that's strictly for Chrome app, so it probably doesn't
belong here.

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
File build/android/run_update_verification.py (right):

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:24: logging.info('Installing %s...',
from_apk)
I made from_apk optional for both modes.

On 2013/01/02 17:23:41, klundberg wrote:
> Seems like it should be possible to call _SaveAppData without installing the
> APK. For example, if a tester has been doing manual testing of the previous
> version  on a given device and already has lots of app data, there is really
no
> need to install the APK.

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:29: raw_input('Set the application
sate. Once ready, press enter and '
On 2013/01/02 17:23:41, klundberg wrote:
> sate/state

Done.

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:36: assert os.path.exists(app_data),
'Backup file doesn not exist!'
On 2013/01/02 17:23:41, klundberg wrote:
> doesn not/does not

Done.

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:89: 'current directory.'))
On 2013/01/02 17:23:41, klundberg wrote:
> How about making it possible to specify the file where you store the data?
That
> would make it easier to provide the --app-data argument when running this for 
> update testing.

Done.

https://codereview.chromium.org/11672004/diff/2001/build/android/run_update_v...
build/android/run_update_verification.py:118: assert
os.path.exists(options.from_apk)
On 2013/01/02 18:26:20, craigdh wrote:
> os.path.isfile instead?

Done.

[frankf, 2013-01-10 23:34:34]

PTAL

[craigdh, 2013-01-10 23:49:21]

lgtm with question/nit.

https://codereview.chromium.org/11672004/diff/12001/build/android/run_update_...
File build/android/run_update_verification.py (right):

https://codereview.chromium.org/11672004/diff/12001/build/android/run_update_...
build/android/run_update_verification.py:108: parser.print_help(sys.stderr)
doesn't parser.error() already print the usage help?

[klundberg, 2013-01-11 00:02:40]

LGTM

Thanks, Frank!