Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9744)

Unified Diff: chrome/service/service_process.h

Issue 1167163002: chrome: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added some missing message_loop.h includes. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/service_ipc_server.cc ('k') | chrome/service/service_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/service_process.h
diff --git a/chrome/service/service_process.h b/chrome/service/service_process.h
index d5942d44531a00c3970da9295fe34033eb0d03e2..8f2aa4cdcfa15c4d8c7762a76f3b0234f6a5c8d1 100644
--- a/chrome/service/service_process.h
+++ b/chrome/service/service_process.h
@@ -46,17 +46,17 @@ class ServiceProcess : public cloud_print::CloudPrintProxy::Client {
bool Teardown();
// TODO(sanjeevr): Change various parts of the code such as
// net::ProxyService::CreateSystemProxyConfigService to take in
- // MessageLoopProxy* instead of MessageLoop*. When we have done that, we can
- // remove the io_thread() and file_thread() accessors and replace them with
- // io_message_loop_proxy() and file_message_loop_proxy() respectively.
+ // SingleThreadTaskRunner* instead of MessageLoop*. When we have done that,
+ // we can remove the io_thread() and file_thread() accessors and replace them
+ // with io_message_loop_proxy() and file_message_loop_proxy() respectively.
// Returns the thread that we perform I/O coordination on (network requests,
// communication with renderers, etc.
// NOTE: You should ONLY use this to pass to IPC or other objects which must
// need a MessageLoop*. If you just want to post a task, use the thread's
- // message_loop_proxy() as it takes care of checking that a thread is still
- // alive, race conditions, lifetime differences etc.
- // If you still must use this, need to check the return value for NULL.
+ // task_runner() as it takes care of checking that a thread is still alive,
+ // race conditions, lifetime differences etc. If you still must use this,
+ // need to check the return value for NULL.
base::Thread* io_thread() const {
return io_thread_.get();
}
« no previous file with comments | « chrome/service/service_ipc_server.cc ('k') | chrome/service/service_process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698