Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1167153002: Remove overly-promiscuous SkNx syntax sugar. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove overly-promiscuous SkNx syntax sugar. I haven't figured out a pithy way to have these apply to only classes originating from SkNx, so let's just remove them. There aren't too many use cases, and it's not really any less readable without them. Semantically, this is a no-op. BUG=skia: Committed: https://skia.googlesource.com/skia/+/f2fe0e03205c4d7f70496ec8c6bea9a82ae88329

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M bench/PMFloatBench.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkNx.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/core/SkRect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/SkNxTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
mtklein_C
5 years, 6 months ago (2015-06-08 18:20:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167153002/1
5 years, 6 months ago (2015-06-08 18:20:41 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/3832)
5 years, 6 months ago (2015-06-08 18:22:49 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167153002/20001
5 years, 6 months ago (2015-06-08 18:27:37 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 19:14:48 UTC) #10
bsalomon
lgtm, thanks!
5 years, 6 months ago (2015-06-10 15:39:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167153002/20001
5 years, 6 months ago (2015-06-10 15:47:19 UTC) #13
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
5 years, 6 months ago (2015-06-10 15:53:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167153002/20001
5 years, 6 months ago (2015-06-10 15:56:50 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 15:57:31 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f2fe0e03205c4d7f70496ec8c6bea9a82ae88329

Powered by Google App Engine
This is Rietveld 408576698