Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 1167073002: Where an ancestor has overflow style, a fixed child needs to be composited. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update expected results. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/mac/compositing/layer-creation/fixed-position-in-fixed-overflow-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
diff --git a/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
index 029fa2bff9e0267b019e263cc92f8a2f9451e8c2..b5fe90799d4c8e4e35eb24993c22140749348424 100644
--- a/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
+++ b/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
@@ -223,6 +223,9 @@ void CompositingRequirementsUpdater::updateRecursive(DeprecatedPaintLayer* ances
if (currentRecursionData.m_compositingAncestor && currentRecursionData.m_compositingAncestor->layoutObject()->isVideo())
directReasons |= CompositingReasonVideoOverlay;
+ if (currentRecursionData.m_hasCompositedScrollingAncestor && layer->layoutObject()->styleRef().hasViewportConstrainedPosition())
+ directReasons |= CompositingReasonPositionFixed;
+
if (compositor->canBeComposited(layer)) {
reasonsToComposite |= directReasons;
« no previous file with comments | « LayoutTests/platform/mac/compositing/layer-creation/fixed-position-in-fixed-overflow-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698