Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1167063002: DevTools: return error when trying to load an empty (0 x 0) picture (Closed)

Created:
4 years, 11 months ago by caseq
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, krit, caseq+blink_chromium.org, pdr+graphicswatchlist_chromium.org, dshwang, yurys+blink_chromium.org, lushnikov+blink_chromium.org, jbroman, danakj, pfeldman+blink_chromium.org, Rik, apavlov+blink_chromium.org, Justin Novosad, devtools-reviews_chromium.org, f(malita), sergeyv+blink_chromium.org, rwlbuis, Stephen Chennney, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: return error when trying to load an empty (0 x 0) picture PNGImageEncoder::encode() will refuse to encode empty-sized bitmap anyway, so fail early by refusing to load empty-sized picture with clear diagnostic. Also, properly reset command counter if clipping before profiling. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
A LayoutTests/inspector-protocol/layers/paint-profiler-load-empty.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/inspector-protocol/layers/paint-profiler-load-empty-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/platform/graphics/PictureSnapshot.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/PictureSnapshot.cpp View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
4 years, 11 months ago (2015-06-05 16:00:10 UTC) #2
caseq
ping
4 years, 10 months ago (2015-06-10 13:42:45 UTC) #3
pfeldman
lgtm
4 years, 10 months ago (2015-06-13 06:39:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167063002/1
4 years, 10 months ago (2015-06-13 07:02:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-13 08:04:17 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197087

Powered by Google App Engine
This is Rietveld 408576698