Chromium Code Reviews
DescriptionRevert of Implement timers by posting delayed tasks (patchset #22 id:420001 of https://codereview.chromium.org/1134523002/)
Reason for revert:
Broke ASAN and blocking Blink rolls.
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/13967
Original issue's description:
> Implement timers by posting delayed tasks
>
> This patch refactors TimerBase to post tasks delayed tasks and
> deletes the now-obsolete timer heap and shared timer mechanism.
>
> ATTN Sheriffs: If there are weird layout test flakes all of a
> sudden, this patch may be the cause since the interleaving of
> timers with other posted tasks will change.
>
> Original patch by Alex Clarke <alexclarke@chromium.org>.
>
> BUG=463143, 416362, 480522
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196308
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196497
TBR=alexclarke@chromium.org,erikcorry@chromium.org,jochen@chromium.org,kinuko@chromium.org,rmcilroy@chromium.org,sigbjornf@opera.com,jchaffraix@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463143, 416362, 480522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196552
Patch Set 1 #
Created: 5 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||