Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(49)

Issue 1167013003: Revert of De-flaking some tests in virtual/gpu/fast/canvas (Closed)

Created:
4 years, 11 months ago by leviw_travelin_and_unemployed
Modified:
4 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of De-flaking some tests in virtual/gpu/fast/canvas (patchset #6 id:100001 of https://codereview.chromium.org/1161463007/) Reason for revert: Caused one odd consistent failure :( junov will look into it tomorrow. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fgpu%2Ffast%2Fcanvas%2FtoDataURL-alpha.html&testType=layout-tests Original issue's description: > De-flaking some tests in virtual/gpu/fast/canvas > > This change uses layoutAndPaintAsyncThen + notifyDone to fix the > flakiness of some canvas layout tests with gpu acceleration enabled. > This approach seems to do the trick locally. This change fixes a > subset of the tests to see if this approach holds up on the test bots. > If it does, the rest of the tests will be fixed in a follow-up change. > > BUG=410929 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196523 TBR=senorblanco@chromium.org,junov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=410929 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +12 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-render-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-resize-after-paint-without-layout.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-state-persistence-no-dirty.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-state-persistence-no-dirty-expected.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-text-baseline.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-text-space-characters.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-identity.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-identity-expected.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-infinity.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-infinity-expected.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-zoom.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-zoom-expected.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/fillrect-gradient-zero-stops.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/fillrect-gradient-zero-stops-expected.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/patternfill-repeat.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/patternfill-repeat-expected.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/canvas/resources/asyncpaintguard.js View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
leviw_travelin_and_unemployed
Created Revert of De-flaking some tests in virtual/gpu/fast/canvas
4 years, 11 months ago (2015-06-04 22:31:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1167013003/1
4 years, 11 months ago (2015-06-04 22:32:18 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 22:33:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196535

Powered by Google App Engine
This is Rietveld 408576698