Add more builders to blacklist to //testing/buildbot/manage.py.

Add more builders to blacklist to //testing/buildbot/manage.py.

This is to help the automation of converting tests to be isolated and run on
Swarming instead of locally.

R=jam@chromium.org
BUG=98637
Committed: https://crrev.com/3a1e46c73087b7602673e5236b83f92bcde3fe62
Cr-Commit-Position: refs/heads/master@{#333106}

[Dirk Pranke, 2015-06-04 20:28:43]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-06-04 20:28:44]

I don't understand this change; we do have the GN bots listed in
//testing/buildbot and manage.py reads them; why do you need to blacklist them
just because none of their tests are using swarming yet?

[M-A Ruel, 2015-06-04 20:33:57]

On 2015/06/04 20:28:44, Dirk Pranke wrote:
> I don't understand this change; we do have the GN bots listed in
> //testing/buildbot and manage.py reads them; why do you need to blacklist them
> just because none of their tests are using swarming yet?

This tool converts tests on all builders to run on Swarming all at once. It's
used to generated CLs automatically. GN is known to not work with Swarming.

[Dirk Pranke, 2015-06-04 20:54:17]

On 2015/06/04 20:33:57, M-A Ruel wrote:
> On 2015/06/04 20:28:44, Dirk Pranke wrote:
> > I don't understand this change; we do have the GN bots listed in
> > //testing/buildbot and manage.py reads them; why do you need to blacklist
them
> > just because none of their tests are using swarming yet?
> 
> This tool converts tests on all builders to run on Swarming all at once. It's
> used to generated CLs automatically. GN is known to not work with Swarming.

Huh? My understanding was that this script is mostly used as a PRESUBMIT check
to make
sure the file is correctly formatted, and that using the -w flag will ensure it
is serialized
out properly.

Is what you're talking about a new thing for this script?

[M-A Ruel, 2015-06-04 20:56:43]

On 2015/06/04 20:54:17, Dirk Pranke wrote:
> On 2015/06/04 20:33:57, M-A Ruel wrote:
> > On 2015/06/04 20:28:44, Dirk Pranke wrote:
> > > I don't understand this change; we do have the GN bots listed in
> > > //testing/buildbot and manage.py reads them; why do you need to blacklist
> them
> > > just because none of their tests are using swarming yet?
> > 
> > This tool converts tests on all builders to run on Swarming all at once.
It's
> > used to generated CLs automatically. GN is known to not work with Swarming.
> 
> Huh? My understanding was that this script is mostly used as a PRESUBMIT check
> to make
> sure the file is correctly formatted, and that using the -w flag will ensure
it
> is serialized
> out properly.
> 
> Is what you're talking about a new thing for this script?

I'm talking about the --convert flag.

[Dirk Pranke, 2015-06-04 21:01:58]

On 2015/06/04 20:56:43, M-A Ruel wrote:
> I'm talking about the --convert flag.

Okay, but your change affects the --write mode also. I would expect that we want
lines 118-127 to execute 
for all of the builders in --write mode, no?

[M-A Ruel, 2015-06-04 21:03:19]

On 2015/06/04 21:01:58, Dirk Pranke wrote:
> On 2015/06/04 20:56:43, M-A Ruel wrote:
> > I'm talking about the --convert flag.
> 
> Okay, but your change affects the --write mode also. I would expect that we
want
> lines 118-127 to execute 
> for all of the builders in --write mode, no?

No, --write is purely a stylistic formatter.

--convert modifies the tests to convert the ones that are not running on
Swarming to run on Swarming, taking in account the blacklist, which I'm updating
here.

[Dirk Pranke, 2015-06-04 21:10:23]

On 2015/06/04 21:03:19, M-A Ruel wrote:
> On 2015/06/04 21:01:58, Dirk Pranke wrote:
> > On 2015/06/04 20:56:43, M-A Ruel wrote:
> > > I'm talking about the --convert flag.
> > 
> > Okay, but your change affects the --write mode also. I would expect that we
> want
> > lines 118-127 to execute 
> > for all of the builders in --write mode, no?
> 
> No, --write is purely a stylistic formatter.
> 
> --convert modifies the tests to convert the ones that are not running on
> Swarming to run on Swarming, taking in account the blacklist, which I'm
updating
> here.

Okay, I missed the upgrade_test() call. However, I clearly found the way this
code 
is written to be confusing; it would be better if the whole loop was pulled into
a different
function bracketed by if args.convert or args.remaining or something like that

Does that make sense?

[jam, 2015-06-04 21:40:04]

I'm not familiar with this file at all, so I would be a bad reviewer here.

[Dirk Pranke, 2015-06-04 22:48:00]

lgtm assuming you make the code slightly clearer :).

[M-A Ruel, 2015-06-05 17:30:30]

On 2015/06/04 22:48:00, Dirk Pranke wrote:
> lgtm assuming you make the code slightly clearer :).

Ok but I'll make it in a separate CL to not confuse 2 separate changes.

[M-A Ruel, 2015-06-05 17:31:46]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-06-05 17:32:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1166993003/1

[commit-bot: I haz the power, 2015-06-05 17:46:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-05 17:46:30]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[M-A Ruel, 2015-06-05 17:47:06]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-06-05 17:50:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1166993003/1

[commit-bot: I haz the power, 2015-06-05 19:15:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-05 19:24:18]

Patchset 1 (id:??) landed as
https://crrev.com/3a1e46c73087b7602673e5236b83f92bcde3fe62
Cr-Commit-Position: refs/heads/master@{#333106}

[Nico, 2015-12-15 17:35:22]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-12-15 17:35:22]

https://codereview.chromium.org/1166993003/diff/1/testing/buildbot/manage.py
File testing/buildbot/manage.py (right):

https://codereview.chromium.org/1166993003/diff/1/testing/buildbot/manage.py#...
testing/buildbot/manage.py:45: 'ClangToTMacASan',
these are not unmaintained