Issue 1166983003: Make FixedHeightScrollable mostly work in fn2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166983003: Make FixedHeightScrollable mostly work in fn2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie, eseidel

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make FixedHeightScrollable mostly work in fn2 We still need to add a clip and a way to integrate with layout, but those changes are more invasive and I'll do them in separate CLs. R=eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/60c10b553182e5bc759c3b24712bfe5a5b6324f9

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -43 lines)			Patch
	M	sky/sdk/lib/framework/components2/fixed_height_scrollable.dart	View		4 chunks	+22 lines, -43 lines	0 comments	Download

Total messages: 6 (2 generated)

abarth-chromium

Committed patchset #1 (id:1) manually as 60c10b553182e5bc759c3b24712bfe5a5b6324f9 (presubmit successful).

5 years, 6 months ago (2015-06-04 17:52:17 UTC) #4

Message was sent while issue was closed.

lgtm