Ignore offset parameter in encode callback. It is ignored/deprecated by the caller, and bitmap.pixe…

content/renderer/gpu/gpu_benchmarking_extension.cc

Index: content/renderer/gpu/gpu_benchmarking_extension.cc
diff --git a/content/renderer/gpu/gpu_benchmarking_extension.cc b/content/renderer/gpu/gpu_benchmarking_extension.cc
index 38c75f5728a695e4e21b463cb4d647ef72548241..aea4e12bbb7ade2005f124ff98269af90b1b4f52 100644
--- a/content/renderer/gpu/gpu_benchmarking_extension.cc
+++ b/content/renderer/gpu/gpu_benchmarking_extension.cc
@@ -46,12 +46,13 @@ using blink::WebView;
 
 const char kGpuBenchmarkingExtensionName[] = "v8/GpuBenchmarking";
 
+// offset parameter is deprecated/ignored, and will be remove from the
+// signature in a future skia release.

[jamesr, 2014/01/07 21:23:16]

could you add a TODO with a link to a bug tracking this removal, or if there
isn't a bug the email of whoever's driving the removal?

[reed1, 2014/01/07 21:28:31]

Done.

 static SkData* EncodeBitmapToData(size_t* offset, const SkBitmap& bm) {
     SkPixelRef* pr = bm.pixelRef();
     if (pr != NULL) {
         SkData* data = pr->refEncodedData();
         if (data != NULL) {

[jamesr, 2014/01/07 21:23:16]

remove the { }s as well since this is now a one-liner

[reed1, 2014/01/07 21:28:31]

Done.

-            *offset = bm.pixelRefOffset();
             return data;
         }
     }