Issue 116693005: Ignore offset parameter in encode callback. It is ignored/deprecated by the caller, and bitmap.pixe…

Issue 116693005: Ignore offset parameter in encode callback. It is ignored/deprecated by the caller, and bitmap.pixe… (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:
jamesr

CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ignore offset parameter in encode callback. It is ignored/deprecated by the caller, and bitmap.pixelRefOffset() is also deprecated BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243461

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : add email for next step, remove {} #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	content/renderer/gpu/gpu_benchmarking_extension.cc	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/116693005/diff/2/content/renderer/gpu/gpu_benchmarking_extension.cc File content/renderer/gpu/gpu_benchmarking_extension.cc (right): https://codereview.chromium.org/116693005/diff/2/content/renderer/gpu/gpu_benchmarking_extension.cc#newcode50 content/renderer/gpu/gpu_benchmarking_extension.cc:50: // signature in a future skia release. could ...

6 years, 11 months ago (2014-01-07 21:23:15 UTC) #2

reed1

https://codereview.chromium.org/116693005/diff/2/content/renderer/gpu/gpu_benchmarking_extension.cc File content/renderer/gpu/gpu_benchmarking_extension.cc (right): https://codereview.chromium.org/116693005/diff/2/content/renderer/gpu/gpu_benchmarking_extension.cc#newcode50 content/renderer/gpu/gpu_benchmarking_extension.cc:50: // signature in a future skia release. On 2014/01/07 ...

6 years, 11 months ago (2014-01-07 21:28:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/116693005/120001

6 years, 11 months ago (2014-01-07 21:30:58 UTC) #4

Message was sent while issue was closed.

Change committed as 243461

Expand Messages | Collapse Messages