Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Issue 1166923003: Revert of compositor-worker: Share a thread and an isolate for compositor workers. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
kinuko, haraken, sadrul
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of compositor-worker: Share a thread and an isolate for compositor workers. (patchset #13 id:300001 of https://codereview.chromium.org/1158443008/) Reason for revert: Fails to compile on "WebKit Win x64 Builder", http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/49353 Original issue's description: > compositor-worker: Share a thread and an isolate for compositor workers. > > Notable changes: > > . WorkerThread: Move thread initialization/shutdown into virtual methods, so > that CompositorWorkerThread can override the behaviour to allow multiple > compositor workers to safely share the same thread. > . CompositorWorkerManager: Responsible for managing the WebThreadSupportingGC > and v8::Isolate for the compositor workers. It essentially keeps a ref-count > for the thread and isolate and decides when to shutdown/initialize a thread > or isolate. > > BUG=436932 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196625 TBR=kinuko@chromium.org,haraken@chromium.org,sadrul@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=436932 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -512 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerThread.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 5 chunks +4 lines, -16 lines 0 comments Download
M Source/modules/InitModules.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
D Source/modules/compositorworker/CompositorWorkerManager.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/modules/compositorworker/CompositorWorkerManager.cpp View 1 chunk +0 lines, -150 lines 0 comments Download
D Source/modules/compositorworker/CompositorWorkerManagerTest.cpp View 1 chunk +0 lines, -231 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerThread.h View 1 chunk +3 lines, -12 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerThread.cpp View 2 chunks +3 lines, -32 lines 0 comments Download
M Source/modules/compositorworker/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of compositor-worker: Share a thread and an isolate for compositor workers.
5 years, 6 months ago (2015-06-06 08:55:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166923003/1
5 years, 6 months ago (2015-06-06 08:55:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196626
5 years, 6 months ago (2015-06-06 08:56:21 UTC) #3
haraken
5 years, 6 months ago (2015-06-06 10:29:20 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698