Support dragging panels to stack and snap.

chrome/browser/ui/panels/panel.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel.h"
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
 #include "chrome/browser/extensions/api/tabs/tabs_windows_api.h"
 #include "chrome/browser/extensions/api/tabs/windows_event_router.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/extensions/window_controller_list.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/panel_collection.h"
 #include "chrome/browser/ui/panels/panel_host.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
+#include "chrome/browser/ui/panels/stacked_panel_collection.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/gfx/image/image.h"
@@ skipping 200 matching lines @@
 }
 
 Profile* Panel::profile() const {
   return profile_;
 }
 
 const std::string Panel::extension_id() const {
   return web_app::GetExtensionIdFromApplicationName(app_name_);
 }
 
+StackedPanelCollection* Panel::stack() const {
+  return collection_->type() == PanelCollection::STACKED ?
+      static_cast<StackedPanelCollection*>(collection_) : NULL;
+}
+
 content::WebContents* Panel::GetWebContents() const {
   return panel_host_.get() ? panel_host_->web_contents() : NULL;
 }
 
 bool Panel::CanMinimize() const {
   return collection_ && collection_->CanMinimizePanel(this) && !IsMinimized();
 }
 
 bool Panel::CanRestore() const {
   return collection_ && collection_->CanMinimizePanel(this) && IsMinimized();
@@ skipping 501 matching lines @@
 }
 
 void Panel::OnWindowClosing() {
   if (GetWebContents()) {
     native_panel_->DetachWebContents(GetWebContents());
     panel_host_->DestroyWebContents();
   }
 }
 
 string16 Panel::GetWindowTitle() const {
+  // |contents| can be NULL during the window's creation.
   content::WebContents* contents = GetWebContents();
-  string16 title;
-
-  // |contents| can be NULL during the window's creation.
   if (contents) {
-    title = contents->GetTitle();
+    string16 title = contents->GetTitle();
     FormatTitleForDisplay(&title);
+    if (!title.empty())
+      return title;
   }
 
-  if (title.empty())
-    title = UTF8ToUTF16(app_name());
-
-  return title;
+  // Then try the extension manifest name. At last, app name is used.

[Dmitry Titov, 2013/01/09 02:29:50]

This is unrelated change. Can it be moved to a separate patch?

[jianli, 2013/01/09 21:00:59]

Done.

+  const extensions::Extension* extension = GetExtension();
+  return UTF8ToUTF16(extension && !extension->name().empty() ?
+      extension->name() : app_name());
 }
 
 // static
 void Panel::FormatTitleForDisplay(string16* title) {
   size_t current_index = 0;
   size_t match_index;
   while ((match_index = title->find(L'\n', current_index)) != string16::npos) {
     title->replace(match_index, 1, string16());
     current_index = match_index;
   }
@@ skipping 10 matching lines @@
 void Panel::LoadingStateChanged(bool is_loading) {
   command_updater_.UpdateCommandEnabled(IDC_STOP, is_loading);
   native_panel_->UpdatePanelLoadingAnimations(is_loading);
   UpdateTitleBar();
 }
 
 void Panel::WebContentsFocused(content::WebContents* contents) {
   native_panel_->PanelWebContentsFocused(contents);
 }
 
+void Panel::UpdateStackingProperty() {
+  native_panel_->UpdatePanelStackingProperty();
+}
+
+void Panel::MoveBy(const gfx::Vector2d& delta_origin) {

[Dmitry Titov, 2013/01/09 02:29:50]

Naming: MoveByInstantly would better reflect what this is doing.

[jianli, 2013/01/09 21:00:59]

Done.

+  gfx::Rect bounds = GetBounds();
+  bounds.Offset(delta_origin);
+  SetPanelBoundsInstantly(bounds);
+}
+
 const extensions::Extension* Panel::GetExtension() const {
   ExtensionService* extension_service =
       extensions::ExtensionSystem::Get(profile())->extension_service();
   if (!extension_service || !extension_service->is_ready())
     return NULL;
   return extension_service->GetExtensionById(extension_id(), false);
 }
 
 void Panel::UpdateAppIcon() {
   const extensions::Extension* extension = GetExtension();
@@ skipping 17 matching lines @@
     app_icon_ = image;
     native_panel_->UpdatePanelTitleBar();
   }
   app_icon_loader_.reset();
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PANEL_APP_ICON_LOADED,
       content::Source<Panel>(this),
       content::NotificationService::NoDetails());
 }