chrome/browser/net/chrome_url_request_context.cc - Issue 11669012: Convert ProtocolHandlerRegistry::Interceptor to a net::URLRequestJobFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_url_request_context.cc

Issue 11669012: Convert ProtocolHandlerRegistry::Interceptor to a net::URLRequestJobFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address erikwright's comments Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/custom_handlers/protocol_handler_registry.cc ('K') | « chrome/browser/net/chrome_url_request_context.h ('k') | chrome/browser/profiles/off_the_record_profile_io_data.h » ('j') | chrome/browser/profiles/profile_io_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_url_request_context.cc

diff --git a/chrome/browser/net/chrome_url_request_context.cc b/chrome/browser/net/chrome_url_request_context.cc

index 677ed0a7ca76103e7072a6364f309bbe6b5f7611..b3642934a8adac24d0544026316d7970b8a1e0f5 100644

--- a/chrome/browser/net/chrome_url_request_context.cc

+++ b/chrome/browser/net/chrome_url_request_context.cc

@@ -71,7 +71,7 @@ class FactoryForIsolatedApp : public ChromeURLRequestContextFactory {

FactoryForIsolatedApp(const ProfileIOData* profile_io_data,

const StoragePartitionDescriptor& partition_descriptor,

ChromeURLRequestContextGetter* main_context,

- scoped_ptr<net::URLRequestJobFactory::Interceptor>

+ scoped_ptr<ProtocolHandlerRegistry::JobFactory>

protocol_handler_interceptor)

: profile_io_data_(profile_io_data),

partition_descriptor_(partition_descriptor),

@@ -94,7 +94,7 @@ class FactoryForIsolatedApp : public ChromeURLRequestContextFactory {

const StoragePartitionDescriptor partition_descriptor_;

scoped_refptr<ChromeURLRequestContextGetter>

main_request_context_getter_;

- scoped_ptr<net::URLRequestJobFactory::Interceptor>

+ scoped_ptr<ProtocolHandlerRegistry::JobFactory>

protocol_handler_interceptor_;

};

@@ -211,7 +211,7 @@ ChromeURLRequestContextGetter::CreateOriginalForIsolatedApp(

Profile* profile,

const ProfileIOData* profile_io_data,

const StoragePartitionDescriptor& partition_descriptor,

- scoped_ptr<net::URLRequestJobFactory::Interceptor>

+ scoped_ptr<ProtocolHandlerRegistry::JobFactory>

protocol_handler_interceptor) {

DCHECK(!profile->IsOffTheRecord());

ChromeURLRequestContextGetter* main_context =

@@ -258,7 +258,7 @@ ChromeURLRequestContextGetter::CreateOffTheRecordForIsolatedApp(

Profile* profile,

const ProfileIOData* profile_io_data,

const StoragePartitionDescriptor& partition_descriptor,

- scoped_ptr<net::URLRequestJobFactory::Interceptor>

+ scoped_ptr<ProtocolHandlerRegistry::JobFactory>

protocol_handler_interceptor) {

DCHECK(profile->IsOffTheRecord());

ChromeURLRequestContextGetter* main_context =