Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 11669004: Add chromium support for MediaStreamAudioDestinationNode - part II (Closed)

Created:
8 years ago by henrika (OOO until Aug 14)
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

--- This CL is based on https://codereview.chromium.org/11369171/ --- Add chromium support for MediaStreamAudioDestinationNode BUG=none TEST=add here

Patch Set 1 #

Patch Set 2 : Test version which removes microphone hardware dependency #

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -41 lines) Patch
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 1 7 chunks +78 lines, -19 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 6 chunks +30 lines, -21 lines 0 comments Download
A content/renderer/media/webaudio_capturer_source.h View 1 chunk +69 lines, -0 lines 0 comments Download
A content/renderer/media/webaudio_capturer_source.cc View 1 1 chunk +95 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 1 1 chunk +26 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Chris, I have uploaded a test version where I try to illustrate a way to ...
7 years, 12 months ago (2012-12-28 09:46:20 UTC) #1
henrika (OOO until Aug 14)
To test, use: http://www.corp.google.com/~henrika/WebAudio/MediaStreamAudioDestinationNode.html The AEC is still on => audio level is "pumping". Known ...
7 years, 12 months ago (2012-12-28 09:52:22 UTC) #2
Chris Rogers
Thanks Henrik, I was able to get your improved version working using your simplified demo. ...
7 years, 11 months ago (2013-01-04 01:52:16 UTC) #3
henrika (OOO until Aug 14)
7 years, 11 months ago (2013-01-04 10:29:15 UTC) #4
Great Chris, I will take a look when I am back on Monday!

Hope I did not complicate things bug uploading a second version. I assume we can
keep this CL as temp to exchange ideas until we are done.

Powered by Google App Engine
This is Rietveld 408576698