Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1166833002: Add a deprecation message for shadow-piercing descendant combinators and shadow pseudo elements. (Closed)

Created:
5 years, 6 months ago by hayato
Modified:
4 years, 3 months ago
Reviewers:
esprehn, dglazkov, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a deprecation message for shadow-piercing descendant combinators and shadow pseudo elements. Deprecate /deep/ and '::shadow'. "Intent to Deprecate" is here: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/68qSZM5QMRQ/pT2YCqZSomAJ Note that there is a plan to support these selectors in the static profile, however, this is still in the discussion. I'll support these selectors again in the static profile in another patch when the discussion settles down. This CL deprecates all usages of these selectors, both in the static profile and the dynamic profile. BUG=489954 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196442

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebase further #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M LayoutTests/fast/css/invalidation/detach-reattach-shadow-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/invalidation/shadow-boundary-crossing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/SelectorAPI/only-shadow-host-in-shadow-tree-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/all-in-shadow-tree-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-deep-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-pseudo-element-with-shadow-pseudo-element-and-host-pseudo-class-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/dynamically-added-deep-combinator-and-shadow-pseudo-element-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-for-multiple-shadowroots-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-for-useragent-shadowroot-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-with-detached-node-distribution-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-with-distribution-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-with-shadow-all-and-shadow-deep-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-pseudo-element-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-and-shadow-element-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-deep-combinator-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/stylesheets-order-in-shadow-dom-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hayato
PTAL
5 years, 6 months ago (2015-06-03 11:49:12 UTC) #2
dglazkov
lgtm
5 years, 6 months ago (2015-06-03 14:42:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166833002/40001
5 years, 6 months ago (2015-06-04 00:58:22 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 01:03:58 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196442

Powered by Google App Engine
This is Rietveld 408576698