Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2623)

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 1166793002: Oilpan: add assert to verify eager finalization. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/platform/heap/Heap.h ('K') | « Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/ThreadState.cpp
diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp
index e4c8669990f7e6c3652fdec1903c184ca9ddc586..5facbac9e165ec4863491482e0d8b784d839d2ef 100644
--- a/Source/platform/heap/ThreadState.cpp
+++ b/Source/platform/heap/ThreadState.cpp
@@ -88,14 +88,11 @@ ThreadState::ThreadState()
, m_startOfStack(reinterpret_cast<intptr_t*>(StackFrameDepth::getStackStart()))
, m_endOfStack(reinterpret_cast<intptr_t*>(StackFrameDepth::getStackStart()))
, m_safePointScopeMarker(nullptr)
- , m_atSafePoint(false)
, m_interruptors()
- , m_sweepForbidden(false)
, m_noAllocationCount(0)
, m_gcForbiddenCount(0)
, m_vectorBackingHeapIndex(Vector1HeapIndex)
, m_currentHeapAges(0)
- , m_isTerminating(false)
, m_gcMixinMarker(nullptr)
, m_shouldFlushHeapDoesNotContainCache(false)
, m_gcState(NoGCScheduled)
@@ -106,6 +103,12 @@ ThreadState::ThreadState()
#if ENABLE(GC_PROFILING)
, m_nextFreeListSnapshotTime(-std::numeric_limits<double>::infinity())
#endif
+ , m_atSafePoint(false)
+ , m_isTerminating(false)
+ , m_isSweepForbidden(false)
+#if ENABLE(ASSERT)
+ , m_isEagerlySweeping(false)
+#endif
{
checkThread();
ASSERT(!**s_threadSpecific);
@@ -651,7 +654,7 @@ void ThreadState::performIdleLazySweep(double deadlineSeconds)
return;
bool sweepCompleted = true;
- ThreadState::SweepForbiddenScope scope(this);
+ SweepForbiddenScope scope(this);
{
if (isMainThread())
ScriptForbiddenScope::enter();
@@ -983,7 +986,7 @@ void ThreadState::eagerSweep()
if (sweepForbidden())
return;
- ThreadState::SweepForbiddenScope scope(this);
+ SweepForbiddenScope scope(this);
{
if (isMainThread())
ScriptForbiddenScope::enter();
@@ -1007,7 +1010,7 @@ void ThreadState::completeSweep()
if (sweepForbidden())
return;
- ThreadState::SweepForbiddenScope scope(this);
+ SweepForbiddenScope scope(this);
{
if (isMainThread())
ScriptForbiddenScope::enter();
« Source/platform/heap/Heap.h ('K') | « Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698