Oilpan: add assert to verify eager finalization.

Oilpan: add assert to verify eager finalization.

A class annotated with EAGERLY_FINALIZE() is dependent on having
an 'operator new' overload that takes eagerness correctly into
account. The use of a EAGERLY_FINALIZE() declaration does not
guarantee this, so add an assert to catch classes not correctly
handled.

R=haraken
BUG=491488
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196404

[sof, 2015-06-02 21:39:45]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-06-02 21:39:45]

please take a look.

[haraken, 2015-06-03 03:52:34]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-06-03 03:52:35]

Looks good with nit.

https://codereview.chromium.org/1166793002/diff/1/Source/platform/heap/Heap.h
File Source/platform/heap/Heap.h (right):

https://codereview.chromium.org/1166793002/diff/1/Source/platform/heap/Heap.h...
Source/platform/heap/Heap.h:1152:
ASSERT(ThreadState::current()->isEagerlySweeping());

Instead of introducing isEagerlySweeping(), you might want to check that the
index of the heap page that this object belongs to is EagerHeapPageIndex.

[sof, 2015-06-03 11:35:16]

https://codereview.chromium.org/1166793002/diff/1/Source/platform/heap/Heap.h
File Source/platform/heap/Heap.h (right):

https://codereview.chromium.org/1166793002/diff/1/Source/platform/heap/Heap.h...
Source/platform/heap/Heap.h:1152:
ASSERT(ThreadState::current()->isEagerlySweeping());
On 2015/06/03 03:52:35, haraken wrote:
> 
> Instead of introducing isEagerlySweeping(), you might want to check that the
> index of the heap page that this object belongs to is EagerHeapPageIndex.

That gets us there also and with less noise; done.

[haraken, 2015-06-03 11:39:55]

LGTM

[sof, 2015-06-03 11:52:13]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-06-03 11:52:13]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1166793002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2015-06-03 11:52:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1166793002/40001

[commit-bot: I haz the power, 2015-06-03 14:37:27]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196404