Do not always attempt to configure third party VPNs

Do not always attempt to configure third party VPNs

BUG=487633
Committed: https://crrev.com/e6f8dddea9f10da7b0a15d427da1e62376a5f37f
Cr-Commit-Position: refs/heads/master@{#332722}

[stevenjb, 2015-06-02 22:48:39]

stevenjb@chromium.org changed reviewers:
+ bartfab@chromium.org

[stevenjb, 2015-06-02 22:48:40]

Sorry this took so long to get to, been busy on other things. Let me know if you
would like me to merge this to 44 and I will poke at the TPMs.

[bartfab (slow), 2015-06-02 23:55:27]

https://codereview.chromium.org/1166763003/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/1166763003/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/chromeos/internet_detail.js:1235:
!onc.getActiveValue('Connectable')) {
The first part of the conditional makes sense of course. But I am not sure about
"!onc.getActiveValue('Connectable')". We would only ever reach that for
third-party VPNs. But there, showing the configuration dialog when the user
clicks "Connect" is always an error. The user has no way to connect from within
that dialog.

[stevenjb, 2015-06-03 01:14:57]

PTAL

https://codereview.chromium.org/1166763003/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/1166763003/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/chromeos/internet_detail.js:1235:
!onc.getActiveValue('Connectable')) {
On 2015/06/02 23:55:26, bartfab wrote:
> The first part of the conditional makes sense of course. But I am not sure
about
> "!onc.getActiveValue('Connectable')". We would only ever reach that for
> third-party VPNs. But there, showing the configuration dialog when the user
> clicks "Connect" is always an error. The user has no way to connect from
within
> that dialog.

I guess the thing to do is to disable the Connect button for VPN when
Conenctable is false, I will change that.

[bartfab (slow), 2015-06-03 22:21:34]

lgtm

[stevenjb, 2015-06-03 22:22:13]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2015-06-03 22:23:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1166763003/20001

[commit-bot: I haz the power, 2015-06-03 23:17:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-03 23:17:49]

Patchset 2 (id:??) landed as
https://crrev.com/e6f8dddea9f10da7b0a15d427da1e62376a5f37f
Cr-Commit-Position: refs/heads/master@{#332722}